Closed Bug 1535742 Opened 5 years ago Closed 4 years ago

Keyboard focus of links not working on Mac

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

65 Branch
Desktop
macOS
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: hassan, Unassigned)

References

Details

(Keywords: regression, regressionwindow-wanted)

I'm not able to navigate links using the keyboard in Firefox. I was able to find a workaround by setting accessibility.tabfocus to 7 in about:config[1]. Is there a reason tab focus is disabled by default? Any clarifications would be appreciated.

[1] https://stackoverflow.com/a/11713537/6150432

OS: Unspecified → macOS
Hardware: Unspecified → Desktop
Summary: Keyboard focus of links → Keyboard focus of links not working on Mac

This is expected behavior on MacOS, given it is the platform convention.
I don't have Safari to test right now, but IIRC it at least used to have similar behavior.
Marking invalid, but Neil may have more to say about this.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(enndeakin)
Resolution: --- → INVALID

Safari has the same behavior as we do.

It works on Chrome.

This is the right behaviour.

Flags: needinfo?(enndeakin)
Resolution: INVALID → DUPLICATE

In MAC the tab-navigation behavior depends on the OS Keyboard setting.
Enabling "Full Keyboard Access" in the Keyboard preference would make link tab navigable.
Note that we don't monitor the os keyboard setting changes dynamically, so you need to restart Firefox after changing the setting.

Resolution: DUPLICATE → INVALID
See Also: → 1592409

(In reply to Edgar Chen [:edgar] from comment #8)

In MAC the tab-navigation behavior depends on the OS Keyboard setting.
Enabling "Full Keyboard Access" in the Keyboard preference would make link tab navigable.
Note that we don't monitor the os keyboard setting changes dynamically, so you need to restart Firefox after changing the setting.

The number of duplicates and similar bugs filed only recently suggests that something regressed here. Somebody should take a closer look.

Status: RESOLVED → REOPENED
Resolution: INVALID → ---
See Also: → 1597666
Type: enhancement → defect
See Also: → 1593211
Priority: -- → P3

I'm unclear what the bug is here. Tab navigation of links seems to work ok for me.

Flags: needinfo?(dao+bmo)

I don't know and can't check myself -- I only saw a number of bugs filed on this recently in Firefox::Keyboard Navigation (see Duplicates and See Also).

Flags: needinfo?(dao+bmo)

[:edg(In reply to Edgar Chen [:edgar] from comment #8)

In MAC the tab-navigation behavior depends on the OS Keyboard setting.
Enabling "Full Keyboard Access" in the Keyboard preference would make link tab navigable.
Note that we don't monitor the os keyboard setting changes dynamically, so you need to restart Firefox after changing the setting.

I'm not sure which specific control you are referring to in Keyboard Preferences. If you are talking about the "Use keyboard navigation to move focus between controls" then I can tell you that since updating to macOS Catalina, that stopped working for me and I had to set accessibility.tabfocus to 7 in about:config, to make tabbing links work. Is there another control in preferences that I should be using? There is nothing obvious there to me. I am sure you will agree that asking anyone who requires the use of a keyboard to navigate to open about:config is not an acceptable solution. That should be for developer use only, not making the web accessible to disabled people.

See Also: → 1600262

Note that we don't monitor the os keyboard setting changes dynamically, so you need to restart Firefox after changing the setting.

It shouldn't require restarting and doesn't when chrome elements are being navigated. It looks like the keyboard navigation setting state change isn't being propagated down to child processes.

That isn't really a regression though, at least not since multiple processes have been enabled, and I don't see any different behaviour in 10.15

The 'keyboard navigation' preference appears to operate the same in 10.15 although the UI for it was reworded.

I filed bug 1600430 on the child process issue.

Hi, I tried to reproduce this issue on MAC os 10.15.2 with our latest Nightly build as well as Beta 73.0b8 in order to find a regression range but if you set the "Use keyboard navigation to move focus between controls" options in Systems preferences everything works fine. Is this still a valid issue ? if so can someone provide some steps on how to reproduce it ? maybe a test page ?

@mfishe@gmail.com Since this stopped working for you If you're willing, we have a tool called mozregression that will automate the process of downloading various builds from our development cycles to narrow down the change that's causing problems. Information on the tool is available at http://mozilla.github.io/mozregression/. A command like |mozregression --good 2018-10-01 --bad 2020-01-21 should be enough to get started (assuming Fx64 was ok). Thanks!

Flags: needinfo?(mfishe)

(In reply to Rares Doghi from comment #18)

Hi, I tried to reproduce this issue on MAC os 10.15.2 with our latest Nightly build as well as Beta 73.0b8 in order to find a regression range but if you set the "Use keyboard navigation to move focus between controls" options in Systems preferences everything works fine. Is this still a valid issue ? if so can someone provide some steps on how to reproduce it ? maybe a test page ?

@mfishe@gmail.com Since this stopped working for you If you're willing, we have a tool called mozregression that will automate the process of downloading various builds from our development cycles to narrow down the change that's causing problems. Information on the tool is available at http://mozilla.github.io/mozregression/. A command like |mozregression --good 2018-10-01 --bad 2020-01-21 should be enough to get started (assuming Fx64 was ok). Thanks!

Sorry for the late reply. I see it is now working for me. I am not sure when this started working, so can't say what might have been the problem.

Flags: needinfo?(mfishe)

Since this issue no longer occurs I will close it as Works for Me but if it starts to reoccur please reopen it.
Also if you are able to reproduce this issue can you please perform a mozregression in order to pin point the cause of it ?

Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → WORKSFORME

(In reply to Rares Doghi from comment #20)

Since this issue no longer occurs I will close it as Works for Me but if it starts to reoccur please reopen it.
Also if you are able to reproduce this issue can you please perform a mozregression in order to pin point the cause of it ?

OK cool, will do. Still working for me too though.

You need to log in before you can comment on or make changes to this bug.