Closed Bug 1535786 Opened 7 months ago Closed 7 months ago

Expired issuer certificate error page missing current time

Categories

(Firefox :: Security, defect, P2)

63 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: agashlin, Assigned: carolina.jimenez.g, Mentored)

References

Details

Attachments

(1 file)

Visiting https://signed.bad.horse in Nightly, it shows the following text, missing the current date.

"
signed.bad.horse has a security policy called HTTP Strict Transport Security (HSTS), which means that Nightly can only connect to it securely. You can’t add an exception to visit this site.

Your computer clock is set to . Make sure your computer is set to the correct date, time, and time zone in your system settings, and then refresh signed.bad.horse.

If your clock is already set to the right time, the website is likely misconfigured, and there is nothing you can do to resolve the issue. You can notify the website’s administrator about the problem.
"

It seems to be because the substitution only happens on one element matching the wrongSystemTime_systemDate2 id, while there are 4. Putting the es_nssBadCert_SEC_ERROR_EXPIRED_ISSUER_CERTIFICATE div before es_nssBadCert_SEC_ERROR_EXPIRED_CERTIFICATE makes this case work, but of course that doesn't help in general.

Johann, can you help triage / move this to where it belongs? Thanks.

Flags: needinfo?(jhofmann)

Oh, yeah, that needs fixing, thanks!

Flags: needinfo?(jhofmann)
Priority: -- → P2
Assignee: nobody → carolina.jimenez.g
Mentor: jhofmann
Status: NEW → ASSIGNED

The solution is to get which of all the errors is being shown in the web page, we can know that resting msg.data.code with the bases and getting which is the name of the parent div where we need to put the date on its child with id="wrongSystemTime_systemDate2".

Keywords: checkin-needed

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1fff0c2e7990
Fix the missing current date. r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.