1535866 - Crash in [@ mozilla::gfx::DrawTargetD2D1::CreateGradientStops]

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[[:philipp]]

This bug is for crash report bp-828147dd-5ef9-45eb-ba10-c61430190315.

Top 8 frames of crashing thread:

0 xul.dll struct already_AddRefed<mozilla::gfx::GradientStops> mozilla::gfx::DrawTargetD2D1::CreateGradientStops gfx/2d/DrawTargetD2D1.cpp:1139
1 xul.dll mozilla::gfx::gfxGradientCache::GetOrCreateGradientStops gfx/thebes/gfxGradientCache.cpp:191
2 xul.dll class mozilla::gfx::GradientStops* mozilla::dom::CanvasGradient::GetGradientStopsForTarget dom/canvas/CanvasGradient.h:35
3 xul.dll class mozilla::gfx::Pattern& const mozilla::dom::CanvasGeneralPattern::ForStyle dom/canvas/CanvasRenderingContext2D.cpp:272
4 xul.dll mozilla::dom::CanvasRenderingContext2D::Fill dom/canvas/CanvasRenderingContext2D.cpp:2603
5 xul.dll static bool mozilla::dom::CanvasRenderingContext2D_Binding::fill dom/bindings/CanvasRenderingContext2DBinding.cpp
6 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3144
7  @0x290835207fc 

this crash signature has started showing up since 67.0a1 build 20190307094951 and the 66 release candidate builds on beta.

Comment 1

[Jessie [:jbonisteel] pls NI]

Hey Bas - can you take a peak at this? Wondering if it has been caused by 1521774

Comment 2

[Bas Schouten (:bas.schouten)]

Seems very likely.

Comment 3

[Andrew Overholt [:overholt]]

I guess we can keep this for a ride-along with a potential 66.0.3?

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

I don't think that's necessary since the crash volume isn't super high at this point. But happy to take an uplift for beta here.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Too late for 66 but tracking for 67.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Bas, could you give us a status update on this crash? Thanks

Comment 7

[Bas Schouten (:bas.schouten)]

Hmm. I'll put up a patch for this somewhere the next week.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Bas Schouten (:bas.schouten) from comment #7)

Hmm. I'll put up a patch for this somewhere the next week.

Any news about your patch? thanks

Comment 9

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt

Depends on D29105

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Bas, it seems that this patch got r+ and is minimal, could you land it and request an uplift to our last beta? Thanks

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cab2047fa7a
Check if a valid DeviceContext is available before attempting to use it. r=rhunt

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6cab2047fa7a

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Ryan, could you make an uplift request today as the reviewer please? Thanks

Comment 14

[Bas Schouten (:bas.schouten)]

Comment on attachment 9061200 [details]
Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt

Beta/Release Uplift Approval Request

• User impact if declined: Crashes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple nullcheck.
• String changes made/needed: None

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9061200 [details]
Bug 1535866: Check if a valid DeviceContext is available before attempting to use it. r=rhunt

Crash fix, ok for uplift. This should make it into the 67 RC build.

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/06f7ac4473b0