Closed Bug 1535931 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15812 - Selection and document.open()

Categories

(Core :: DOM: Selection, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15812 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15812
Details from upstream follow.

Anne van Kesteren <annevk@annevk.nl> wrote:

Selection and document.open()

Chrome fails this, interestingly enough, but Firefox and Safari both pass.

cc @bzbarsky @TimothyGu @domenic

Component: web-platform-tests → Selection
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/56e5f1e1236a
[wpt PR 15812] - Selection and document.open(), a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

It looks like this failed to remove testing/web-platform/meta/selection/Document-open.html.ini which I think is a no-op now: the failure it talks about can't happen because there is no longer a "Selection must be replaced with a new object after document.open()" test.

Would it be possible to have the harness treat bogus annotations like that as a failure?

Flags: needinfo?(james)

It looks like this failed to remove testing/web-platform/meta/selection/Document-open.html.ini

https://phabricator.services.mozilla.com/D30166 tracks fixing that.

Yeah, the confusion caused by having stale annotiations in the tree has bitten a few people recently. I'm planning to look at that after I'm done with the sync work that's currently in progress; there's a patch I started earlier in the year to overhaul the metadata update, but it didn't ever land. I can roll this into that.

Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.