1535942 - Migrate/update themes from "old" lightweight (LTW/Persona) version to "new" (static/extension) version automatically in Mozilla Firefox

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Migrate/update themes from old version to new version.

I have installed my "old" lightweight theme (LTW/Persona) "Virtualfox", and to 2019-01-21, I had about 450 daily users. From 2019-01-22 I have less than 5 daily users. I suspect that Statistics Dashboard shows only new themes version data. So looks like migrating/updating themes from old version to new version is have to Statistics Dashboard show proper and valid data, and also to not duplicating old and new themes versions, like it can be done now with my "new" theme (static/extension) "Virtualfox".

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Themes tab in Add-ons Manager-about:addons.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: old Theme version.png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: new Theme version.png

Comment 4

[Andrew Swan [:aswan]]

I don't understand what you're reporting here. If this is about statistics on AMO, please report this at https://github.com/mozilla/addons/issues

If this is about something in the browser, please give a clear description of exactly what you expected and how what is actually happening is different from what you expected.

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm reporting here that Mozilla Firefox browser should automatically update "old" version of lightweight (LTW/Persona) themes (comment #2) to "new" version of themes (static/extension) (comment #3).

It's to prevent having duplicate themes (Comment #1) and it's inconsistency (Comment #1) in showing in Theme tab in Add-ons Manager-about:addons.
Also it's also to fix "Statistics Dashboard" data, as it only showing now "new" version of themes (static/extension) data, "old" lightweight theme (LTW/Persona) data looks omitted.

Comment 6

[Andrew Swan [:aswan]]

Again, issues with the statistics on AMO need to be filed against the AMO bug tracker, see comment 4.

As for the duplicate theme, this sounds vaguely like bug 1508777, though that was fixed several releases ago.
Do you happen to know when this happened? (ie, did it happen when the browser version updated?) This report mentions Firefox 67, I take it you are using Nightly?

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Seems like I'm still misunderstood, and I don't know, if I can explain it more clearly, than I've already done in comment #5. But I will try. Please see also my attachments, while reading it, maybe they will help.

This bug is about automatically migrate/update "old" version of lightweight (LTW/Persona) themes (comment #2) to "new" version of themes (static/extension) (comment #3) in Mozilla Firefox browser.

So when user has "old" version of lightweight (LTW/Persona) theme (comment #2),
Mozilla Firefox browser will update this "old" version of lightweight (LTW/Persona) theme (comment #2)
to "new" version of theme (static/extension) (comment #3)
with removing "old" version of lightweight (LTW/Persona) theme (comment #2)
so only "new" version of theme (static/extension) (comment #3) will stay under Theme tab in Add-ons manager in Mozilla Firefox browser.

It will prevent having duplicate themes (Comment #1) and it's inconsistency (Comment #1) in showing in Theme tab in Add-ons Manager-about:addons.
It will also fix "Statistics Dashboard" data, as it only showing now "new" version of themes (static/extension) data, "old" lightweight theme (LTW/Persona) data looks omitted.

About bug #1508777, yes, I'm using Mozilla Firefox Nightly, now version 68.0a1 (2019-03-18) (64-bit), on Windows 7 (64-bit), as it's stated in: "Version:", "Platform:", "status-firefox:". My lightweight (LTW/Persona) theme named "Virtualfox" wasn't updated automatically to "new" version of themes (static/extension). I done that myself manually, after being mislead by Mozilla extensions website page and seeing that on it I don't have this theme installed after going to theme homepage https://addons.mozilla.org/addon/virtualfox/

Comment 8

[Neha Kochar [:neha]]

Marking it fix-optional for 67 after offline confirmation from :aswan

Comment 9

[Andrew Swan [:aswan]]

Thanks for your patience. I think everything here is explained by the fact that AMO is still in the midst of the transition from lightweight themes (LWTs) to xpi packaged themes. The results are unfortunate but they are temporary.

The problem on the browser side is that the browser doesn't actually know when an LWT and an xpi theme are actually two different versions of what should appear to the user as a single theme. This is responsible for:

1. the issue in which AMO offers the "Install Theme" button if the equivalent LWT is already installed, and
2. the issue in which the LWT and xpi versions of a single theme can both be installed simultaneously, which appears as if the theme is duplciated

These issues will be cleared up when AMO migrates existing installed LWTs to their xpi equivalents, which I believe is schedule to happen next week.

Closing since I don't think there's any more unexplained behavior, if I've overlooked something please explain it clearly and in detail.

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

So when user will have "old" lightweight (LTW/Persona) theme version installed, it won't be updated to "new" (static/extension) theme version version automatically, leaving in future user without any used non-default theme per removing support for "old" lightweight (LTW/Persona) theme in Mozilla Firefox browser in bug #1469930?

Comment 11

[Andrew Swan [:aswan]]

No, as I said in comment 9, AMO will migrate installed LWTs to the new format next week.

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that issue is now fixed for me in todays Mozilla Firefox Nightly 68.0a1 (2019-03-23) (64-bit). I had only one theme installed in Mozilla Firefox to test how this migration in comment #9 will work, and today my "old version" of lightweight theme (LTW/Persona) named "Virtualfox", updated automatically to "new version" of theme (static/extension).

Thank you very much! \o/
Also thank you very much for your patience too.