Closed
Bug 1535948
Opened 5 years ago
Closed 5 years ago
Code never executed in util.py
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
The indentation level of the else: isn't correct.
raise won't be executed:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/util.py#837
we should either re-indent it or delete it
(it has been this way for a while - 2013)
|
||
Comment 2•5 years ago
|
||
Yeah, looks like it should be indented to re-raise OSErrors that have e.error != error.EACCES, since EACCES is the only thing it's intending to retry.
Flags: needinfo?(mshal)
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f856c978e0bf Fix the indentation: the code wasn't executed r=mshal
|
||
Updated•5 years ago
|
Assignee: nobody → sledru
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•