Closed Bug 1535948 Opened 9 months ago Closed 9 months ago

Code never executed in util.py

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

The indentation level of the else: isn't correct.
raise won't be executed:
https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/util.py#837

we should either re-indent it or delete it
(it has been this way for a while - 2013)

Michael, what do you think?

Flags: needinfo?(mshal)

Yeah, looks like it should be indented to re-raise OSErrors that have e.error != error.EACCES, since EACCES is the only thing it's intending to retry.

Flags: needinfo?(mshal)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f856c978e0bf
Fix the indentation: the code wasn't executed r=mshal
Assignee: nobody → sledru
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.