1535988 - Synthetic submit event should not trigger form submitting

Status: RESOLVED DUPLICATE of bug 1370630

(Core :: DOM: Core & HTML, defect, P2)

Description

[Xidorn Quan [:xidorn] UTC+11]

Attachment: testcase

Steps to reproduce:

1. open the attached testcase
2. click the "submit" button

Expected result:
The button becomes disabled, and the page doesn't refresh.

Actual result:
The page refreshes.

Explanation:

When the button is clicked, it disables itself and dispatch a submit event to a <form>. This submit event makes the form submit while it shouldn't.

In the HTML spec, firing submit event is one step of form submit algorithm, and its return value is checked for whether the algorithm should continue. Given that, I don't think dispatching a synthetic submit event should trigger the form submitting again. (Unless I'm missing something?)

Chrome doesn't have this behavior, i.e. this synthetic submit event doesn't trigger form submitting.

This cause webcompat issue for login page of https://www.canva.com/ on Android (because it dispatches a submit event manually in some touch event handler, which doesn't affect desktop).

In addition to that, invoking preventDefault() in handler of submit doesn't stop the form submitting when it's triggered by a synthetic submit event.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

This cause webcompat issue for login page of https://www.canva.com/ on Android (because it dispatches a submit event manually in some touch event handler, which doesn't affect desktop).

To make it clearer, Firefox users on Android cannot login to Canva because of this issue.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1535988 - Synthetic submit event should not trigger form submitting, r=baku

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

remote: Follow the progress of your build on Treeherder:
remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d168fa74e5663d7ddcb99128ebc26247b66ab1d
remote: recorded changegroup in replication log in 0.047s

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8c4ac7eacee
Synthetic submit event should not trigger form submitting, r=baku

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c8c4ac7eacee

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16001 for changes under testing/web-platform/tests

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6e1347abf34
backout because bug 1537555, r=backout

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e6e1347abf34

Comment 9

[Firefox Bug Husbandry Bot]

See bug 1547409. Moving webcompat whiteboard tags to project flags.

Comment 10

[Mike Taylor [:miketaylr]]

Should this be closed as a dupe of Bug 1370630?

Comment 11

[Xidorn Quan [:xidorn] UTC+11]

Probably. The description of bug is quite different bug as far as the patch is effectively the same, I guess we can mark them duplicate.

If that bug ends up doing something different, then maybe we should reopen this one.