Closed Bug 1536043 Opened 7 months ago Closed 7 months ago

[remote-dbg-next] Box shadow around cards is cut on the sides

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox68 verified)

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified

People

(Reporter: jdescottes, Assigned: pong7219)

References

(Blocks 1 open bug)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(2 files)

STRs:

  • go to about:debugging-new
  • select This Firefox
  • look at any card container (ie the white boxes)

ER: There should be a boxshadow around all the edges of the container
AR: The box shadow is only shown on top/bottom edges. For the first debug target of a category it is also cut on the top edge.

This is probably caused because the cards have no margin and the box shadow is not visible. Note that even if we add a margin we should preserve the overall alignment of the UI.

Priority: -- → P3

Hi Julian,

I could reproduce this on Nightly 68.0a1. Can I work on this bug?

Thanks!

Flags: needinfo?(jdescottes)

Hi Mellina,

Thank you for offering to take this bug :) I will assign it to you right now.

I see you already worked on remote debugging for Bug 1534499, so you probably know where the code for the new about:debugging is located. Just in case, our React components are under devtools/client/aboutdebugging-new/src/components. You can open the DevTools in about:debugging-new to quickly test CSS changes.

Feel free to ping us in this bug or on slack if you have any question!

Assignee: nobody → pong7219
Status: NEW → ASSIGNED
Flags: needinfo?(jdescottes)
Priority: P3 → P1
Whiteboard: [remote-debugging-reserve]
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fde4dfc0464a
Box shadow around cards is cut on the sides r=jdescottes,ladybenko

Sorry about that! We should indeed make sure the height of the categories remain 0.
We should use margin-inline and padding-inline even in .debug-target-pane__collapsable.

Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f7e0ab887d34
Box shadow around cards is cut on the sides r=jdescottes,ladybenko
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Verified as fixed on Firefox Nightly 68.0a1 (2019-05-20) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.