(In reply to Jan Beich from comment #13)
Not sure what are you trying to prove. -mincoming-stack-boundary=2 is neither in standalone build nor is needed here.
it is needed when we set the flags for
entrypoint_source_files. I said that we need to keep it limited on x86 as you have done in your patches.
How is it related to this bug? I don't see crashes on either i386 (aka x86) or amd64 (aka x86_64).
We don't have crashes because we are on 16-byte stack alignment already in Linux. In comment 1 mentioned that this is due to crashes reported in Bug 1515933.
This is related to this bug because, on Linux, we need to allow the default stack alignment for amd64 but to set the stack alignment explicitly in i386 (previous comment).
Also, in asm/moz.build we need to use the asm/x86_64/linux/config.as for Linux and not the asm/x86_64/config.as.
Looks like I need to revert to v0 i.e., pass -mstack-alignment=16 / -mpreferred-stack-boundary=4 on i386 (aka x86) again. On Linux those are nop but elsewhere using 4-byte stack alignment may to lead to crashes as SSE2 assumes 16-byte alignment. And, if not obvious, BSDs don't force SSE2 on i386 (aka x86) by default unlike Linux.
nice, please note that the change in config.h is already landed.