1536078 - Legacy add-ons having both a manifest.json and _locales don't prompt for restart after installation

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, enhancement)

Description

[Onno Ekker [:nONoNonO UTC+1]]

Installing/upgrading Mail Redirect add-on in Thunderbird 67.0a1 Daily doesn't prompt for restart. It is a legacy add-on with an added manifest.json, in order to be compatible with TB 63+. I have also added a _locales directory in order to have the extensionName and extensionDescription localized and it looks like this causes TB not to prompt for a restart. If I remove the _locales directory from the xpi and the default_locale from manifest.json, I do get a prompt to restart TB.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1536078-extension-install-prompt-1.diff

I think this must've broken a while back when the toolkit people were messing around with install paths.

I've also stopped a warning about unsigned extensions from showing, because we don't do that.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9057211 [details] [diff] [review]
1536078-extension-install-prompt-1.diff

Review of attachment 9057211 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/modules/ExtensionsUI.jsm
@@ +554,5 @@
>          if (progressNotification) {
>            progressNotification.remove();
>          }
>  
> +        info.unsigned = false;

please add a comment that we don't use signing, so won't warn for it

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4764301eccdf
Fix extension install prompt when a restart is required, and stop warning about unsigned extensions; r=mkmelin