1536163 - Replace several optional IPDL unions in dom/ipc with native Maybe support

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

This is more ergonomic and readable

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1536163 - Part 1 - use native Maybe syntax in place of OptionalWebProgressData in IPDL; r?baku

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1536163 - Part 2 - use native Maybe syntax in place of MaybeInfo in IPDL; r?baku

Depends on D23897

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1536163 - Part 2 - use native Maybe syntax in place of MaybePrefValue in IPDL; r?mccr8

Depends on D23898

Comment 4

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1536163 - Part 3 - use native Maybe syntax in place of OptionalShmem in IPDL; r?nika

Depends on D23899

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There is a conflict here. Baku has already those changes for dom/ipc/URLClassifierParent.h: https://hg.mozilla.org/integration/autoland/rev/adea671fd3d2#l4.1

Can you update the patch, please?

Comment 6

[Alex Gaynor [:Alex_Gaynor]]

Ok, I've rebased it out, but phabricator still shows it here. Should be good to land, just ignoring the old "part 2".

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6074174df0d9
Part 1 - use native Maybe syntax in place of OptionalWebProgressData in IPDL; r=baku
https://hg.mozilla.org/integration/autoland/rev/6194cbc69a4c
Part 2 - use native Maybe syntax in place of MaybePrefValue in IPDL; r=mccr8
https://hg.mozilla.org/integration/autoland/rev/0e32946d6a3e
Part 3 - use native Maybe syntax in place of OptionalShmem in IPDL; r=nika

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6074174df0d9
https://hg.mozilla.org/mozilla-central/rev/6194cbc69a4c
https://hg.mozilla.org/mozilla-central/rev/0e32946d6a3e