Closed Bug 1536166 Opened 5 years ago Closed 5 years ago

Dark theme native widgets look bad [Fedora]

Categories

(Core :: Graphics, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1411425

People

(Reporter: nika, Unassigned)

Details

Attachments

(3 files)

Currently, we use native GTK widgets in content when drawing input elements such as text boxes, select dropdowns, etc. This can look poor when using a dark theme, as webpages are generally designed with light UI elements in mind. It's especially bad when a webpage chooses to only customize either the background colour or text colour of one of these elements, as the text then often becomes completely unreadable!

It would be nice to take some approach to improve this situation. A few options which pop into my head:

  1. Don't use native widgets in content

    • Consistent UX for webpages across different themes
    • Avoids sending fingerprintable GTK configurations into content processes.
  2. Correct text colour change mismatches when content changes only one property.

    • This would mean that if a text box was given a new background colour, we would also change the text colour to black unless it was explicitly set, and vice-versa for changing just the text colour.

There might be other good options too :-)

ni? Martin

The attached screenshots are taken on Firefox Nightly in Fedora 29 with the Adwaita-dark application theme.
If it's relevant, I am running with Wayland + WebRender enabled.

Flags: needinfo?(stransky)

See Bug 1411425 for details - content theme removal is the only option here.

Flags: needinfo?(stransky)

As a workaround you can set widget.content.gtk-theme-override value, see https://bugzilla.mozilla.org/show_bug.cgi?id=1283086#c7

Thanks for the reference, I can mark this bug as dup against that. I vaguely remembered that there was a bug for those changes, but wasn't sure of the status of it.

Also good to know about the workaround :-)

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: