Picture-in-Picture is not displayed on high DPI
Categories
(Toolkit :: Video/Audio Controls, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: mconley)
References
Details
Attachments
(4 files)
Screenshot
After enabling media.videocontrols.picture-in-picture.enabled (and restarting Nightly, just in case), I do have a "Picture-in-Picture" item in a video's context menu, but I see no mini-player when I hit it.
There's the "This video is playing in Picture-in-Picture mode" message; another Nightly instance is opened in the Windows taskbar (and when hovering it I do actually see the video playing, in the thumbnail), but no actual PIP.
I've checked maybe it's hidden somehow behind other windows but no.
Nothing appears in the Console (also in Browser Toolbox) when I click the Picture-in-Picture item from the context menu (maybe except for the "Error in parsing value for ‘transform’. Declaration dropped." warning)
This happens also on a clean profile.
|
Assignee | |
Comment 1•5 years ago
|
||
Hi Itiel,
Can you tell me a little bit more about your setup? Do you have multiple displays? Do you have a custom window manager? Can I see a screenshot of your desktop showing the player window in the Windows taskbar?
Windows 10 x64 1809 Hebrew locale. One 24" monitor, DPI set to 150%, resolution 1920x1080.
No window manager.
Screenshot attached.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Very mysterious. From the taskbar, are you able to minimize and restore the Picture-in-Picture window? Does that cause it to appear?
I've checked maybe it's hidden somehow by other windows but no.
Can I assume you've attempted to minimize every other window?
I'm pretty flabbergasted by this - I'll probably end up generating some special builds for you to try to help diagnose this Itiel, if you have the time and are willing.
(In reply to Mike Conley (:mconley) (:⚙️) from comment #4)
Very mysterious. From the taskbar, are you able to minimize and restore the Picture-in-Picture window? Does that cause it to appear?
No.
I've checked maybe it's hidden somehow by other windows but no.
Can I assume you've attempted to minimize every other window?
Yes.
I'm pretty flabbergasted by this - I'll probably end up generating some special builds for you to try to help diagnose this Itiel, if you have the time and are willing.
I have the time and I am willing (I'm a fan of your work, after all!), but allow me to save you (some of) the trouble :)
This is because of the DPI scaling.
I guess that when Nightly activates PIP, it tries to display PIP at the very bottom corner of the screen, but it apparently does not account for DPI.
So in my case (150%), PIP actually does show up, but out of the screen bounds, thus invisible to me.
Setting the DPI to 125% causes PIP to be 3/4 hidden, but the 1/4 of it is enough to allow me to drag it on screen.
DPI 100% behaves totally normal.
|
|
Assignee | |
Comment 6•5 years ago
|
||
but allow me to save you (some of) the trouble :)
You're the best, thank you!
|
|
Assignee | |
Comment 7•5 years ago
|
||
Hi Itiel,
I have some builds for you to try that I think might fix this.
Does this fix the issue for you?
(In reply to Mike Conley (:mconley) (:⚙️) from comment #7)
Hi Itiel,
I have some builds for you to try that I think might fix this.
Does this fix the issue for you?
Pretty much, yes. :)
I've tested in all of my supported DPI settings (100%, 125%, 150% & 175%), and in 150&175% opening a video in PIP mode opens it 1-3 pixels from the screen's edge, as opposed to e.g. when I open it in 100% DPI, there the video pops up 0px above the taskbar, and 0px from the monitor's right side.
See attached.
|
Reporter | |
Comment 10•5 years ago
|
||
|
|
Reporter | |
Comment 11•5 years ago
|
||
Needless to say, both screenshots were taken right after launching the video in PIP mode -- without moving the PIP around the screen.
|
|
Assignee | |
Comment 12•5 years ago
|
||
|
||
Comment 13•5 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f2052d1d03a Account for CSS scale factor when positioning Picture-in-Picture window. r=JSON_voorhees
|
|
Assignee | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 14•5 years ago
|
||
(In reply to Itiel from comment #8)
I've tested in all of my supported DPI settings (100%, 125%, 150% & 175%), and in 150&175% opening a video in PIP mode opens it 1-3 pixels from the screen's edge, as opposed to e.g. when I open it in 100% DPI, there the video pops up 0px above the taskbar, and 0px from the monitor's right side.
I meant to needinfo you on that :)
Is that acceptable? Is there a need to file a new bug about that?
|
|
Assignee | |
Comment 15•5 years ago
|
||
(In reply to Itiel from comment #14)
Is that acceptable? Is there a need to file a new bug about that?
Hey Itiel,
Let's get a new bug on file for that, but I imagine it'll be lower priority until we can get some of the other bits fixed. Thanks!
|
||
Comment 16•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 17•5 years ago
|
||
Hello,
Reproduced the issue with Firefox 68.0a1 (20190318213844) on Windows 10 x64.
The issue is verified using Firefox 69.0a1 (20190605215957) and Firefox 68.0b7 (20190603181408) on Windows 10x64.
Description
•