Closed Bug 1536240 Opened 7 months ago Closed 5 months ago

Add a wrench debug option to dump concatenated shader source to file.

Categories

(Core :: Graphics: WebRender, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: gw, Assigned: gw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-amvp][wr-q2])

Attachments

(1 file)

This can be very useful to enable passing the output through other tools (e.g. mobile platform shader analyzers during shader optimization work).

Assignee: nobody → gwatson
Priority: -- → P2

FWIW, we can extract the shader code from a RenderDoc capture as well.

Whiteboard: [wr-amvp][wr-q2]

Hi, I would like to work on this bug. Could I get some pointers on a good place to start?

Flags: needinfo?(gwatson)

Glenn should be asleep, but in case it helps, this could be a good place to start:

compute_source gives you the full shader source.

(written in collision with :emilio response)
You can start by looking at the shader loading and the corresponding low level functions do_build_shader_string and link_program. Please reach out if you have any questions!

Flags: needinfo?(gwatson)
Attachment #9068537 - Attachment description: Bug 1536240 - Add debug option to wrench to output specified shader source → Bug 1536240 - Add debug option to wrench to output specified shader source r?kvark

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb8c60790fd9
Add debug option to wrench to output specified shader source r=kvark

Keywords: checkin-needed

Looks like the WR bindings fail to build.
Connor, please build and run Firefox for testing before proceeding with the change (try push would be best, but in this case it's not that important).

Flags: needinfo?(gwatson)

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57861a1ded5a
Add debug option to wrench to output specified shader source r=kvark

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.