1536240 - Add a wrench debug option to dump concatenated shader source to file.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Glenn Watson [:gw]]

This can be very useful to enable passing the output through other tools (e.g. mobile platform shader analyzers during shader optimization work).

Comment 1

[Dzmitry Malyshau [:kvark]]

FWIW, we can extract the shader code from a RenderDoc capture as well.

Comment 2

[Connor Brewster [:cbrewster]]

Hi, I would like to work on this bug. Could I get some pointers on a good place to start?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Glenn should be asleep, but in case it helps, this could be a good place to start:

• https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/gfx/wr/webrender/src/device/gl.rs#699

compute_source gives you the full shader source.

Comment 4

[Dzmitry Malyshau [:kvark]]

(written in collision with :emilio response)
You can start by looking at the shader loading and the corresponding low level functions do_build_shader_string and link_program. Please reach out if you have any questions!

Comment 5

[Connor Brewster [:cbrewster]]

Attachment: Bug 1536240 - Add debug option to wrench to output specified shader source r?kvark

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb8c60790fd9
Add debug option to wrench to output specified shader source r=kvark

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset cb8c60790fd9 (Bug 1536240) for causing build bustages CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=cb8c60790fd9a7fcd503e97b83de101daee39e77&selectedJob=249214807

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249214803&repo=autoland&lineNumber=24295

Backout: https://hg.mozilla.org/integration/autoland/rev/6d98129734a866e3b8d97b8397b88022d863a7d8

Comment 8

[Dzmitry Malyshau [:kvark]]

Looks like the WR bindings fail to build.
Connor, please build and run Firefox for testing before proceeding with the change (try push would be best, but in this case it's not that important).

Comment 9

[Connor Brewster [:cbrewster]]

Apologies for that!

try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f2847434eb36758949737f2a599c5b3333f5b23

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57861a1ded5a
Add debug option to wrench to output specified shader source r=kvark

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/57861a1ded5a