1536268 - Attachments, Outgoing: Clicking on box crashes

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

More eval fun:

Assertion failure: false (do not use eval with system privileges), at c:/mozilla
-source/comm-central/caps/nsScriptSecurityManager.cpp:514
#01: js::DirectEval (c:\mozilla-source\comm-central\js\src\builtin\Eval.cpp:440)
#02: Interpret (c:\mozilla-source\comm-central\js\src\vm\Interpreter.cpp:0)
#03: js::RunScript (c:\mozilla-source\comm-central\js\src\vm\Interpreter.cpp:422)
#04: js::ExecuteKernel (c:\mozilla-source\comm-central\js\src\vm\Interpreter.cpp:781)
#05: js::Execute (c:\mozilla-source\comm-central\js\src\vm\Interpreter.cpp:814)

Comment 1

[Geoff Lankow (:darktrojan)]

Protovis :(

June 28, 2011 - Protovis is no longer under active development.

Maybe it's time we stopped using it?

Comment 2

[Jorg K (CEST = GMT+2)]

Hmm, perhaps we can fix something here instead of blowing up the beta :-(

Comment 3

[Geoff Lankow (:darktrojan)]

The debug beta.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1536268-protovis-eval-1.diff

Well it seems the code in question is garbage anyway. Let's just get rid of it.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9051879 [details] [diff] [review]
1536268-protovis-eval-1.diff

And it still works? What did that do anyway?

Comment 6

[Geoff Lankow (:darktrojan)]

I'm not actually sure. It must be a part of the Protovis framework, and exist because we have the whole framework? In any case the line it's evaluating has a syntax error these days.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/54cd0bf83c13
Remove unused code that uses eval from Protovis library. r=jorgk

Comment 8

[:aceman]

So if that eval() has an error, won't the catch block always be run?
So won't we be missing the pv.parse function now that you remove it? But I do not see any calls to it from inside protovis-r2.6-modded.js .

There is also bug 517978 for the brave ones :)

Comment 9

[Jorg K (CEST = GMT+2)]

Thanks for checking. I just applied the patch, clicked on Box and it worked :-)

Comment 10

[Jorg K (CEST = GMT+2)]

TB 67 beta:
https://hg.mozilla.org/releases/comm-beta/rev/39f40f151c57babdd70fdc3c7497d3bdcc720a78