Closed Bug 1536285 Opened 6 months ago Closed 3 months ago

Add Highlights as the final discovery stream section

Categories

(Firefox :: New Tab Page, enhancement, P1)

67 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Iteration:
69.3 - Jun 10 - 23
Tracking Status
firefox69 --- verified

People

(Reporter: wolasi, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged)

Attachments

(2 files)

Add Highlights section to Home/New Tab. It should be displayed beneath the Pocket Stories section. It should use as much of the original code as possible.

Add original settings for Highlights to Preferences

  • Number of rows selector
  • Check boxes for Visited Pages, Bookmarks, Most Recent Download, Pages Saved to Pocket

Implementation should follow Bug 1533601

Preference Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/Home-New-Tab-Spec-for-Fx-v68?node-id=1%3A70

Summary: [Highlights] Add Highlights section → [Highlights] Add Highlights section to Home/New Tab
Blocks: 1533601

Bug 1533601 is adding the preferences other than Highlights but probably should be implemented in similar ways ?

No longer blocks: 1533601
See Also: → 1533601

Yes, it should be implemented in the same way as Bug 1533601
Updated the description.

No longer blocks: 1512725
Keywords: uiwanted
Priority: P1 → P2
Target Milestone: Firefox 68 → Future
Blocks: pocket-newtab
No longer blocks: pocket-newtab-68
Summary: [Highlights] Add Highlights section to Home/New Tab → [Highlights] Add Highlights section to Home/New Tab - TBD
Target Milestone: Future → ---
Iteration: 68.2 - Apr 1 - 14 → ---
Priority: P2 → P1
Priority: P1 → --
Iteration: --- → 69.4 - Jun 24 - Jul 7
Keywords: meta
Priority: -- → P1
Summary: [Highlights] Add Highlights section to Home/New Tab - TBD → [meta] [Highlights] Add Highlights section to Home/New Tab - TBD

If we don't change the server layout response, similar to the heuristic of putting top sites first then pocket next, we could treat highlights as an automatic section that follows pocket.

Summary: [meta] [Highlights] Add Highlights section to Home/New Tab - TBD → [meta] Add Highlights as the final discovery stream section
Assignee: nobody → edilee
Iteration: 69.4 - Jun 24 - Jul 7 → 69.3 - Jun 10 - 23
Keywords: meta
Summary: [meta] Add Highlights as the final discovery stream section → Add Highlights as the final discovery stream section
Blocks: 1559536
Status: NEW → RESOLVED
Closed: 3 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

I have verified that the Highlights section appears under the Recommended by Pocket section on the latest Nightly 69.0a1 (Build ID 20190619095537) on Windows 10, macOS 10.14, and Arch Linux 4.14.3. I have also verified that the section can be collapsed/expanded, turned off/on, and that Visited Pages, Bookmarks, Most Recent Download, and Pages Saved to Pocket can be filtered out.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.