1536285 - Add Highlights as the final discovery stream section

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Wolasi :wolasi]

Add Highlights section to Home/New Tab. It should be displayed beneath the Pocket Stories section. It should use as much of the original code as possible.

Add original settings for Highlights to Preferences

• Number of rows selector
• Check boxes for Visited Pages, Bookmarks, Most Recent Download, Pages Saved to Pocket

Implementation should follow Bug 1533601

Preference Spec
https://www.figma.com/file/0xZkmT86rSXbGRB4eIvrn0ts/Home-New-Tab-Spec-for-Fx-v68?node-id=1%3A70

Comment 1

[Ed Lee :Mardak]

Bug 1533601 is adding the preferences other than Highlights but probably should be implemented in similar ways ?

Comment 2

[Wolasi :wolasi]

Yes, it should be implemented in the same way as Bug 1533601
Updated the description.

Comment 3

[Wolasi :wolasi]

Attachment: Original implementation of HIghlights for reference

Comment 4

[Ed Lee :Mardak]

If we don't change the server layout response, similar to the heuristic of putting top sites first then pocket next, we could treat highlights as an automatic section that follows pocket.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5118

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/0dff9f803849

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the Highlights section appears under the Recommended by Pocket section on the latest Nightly 69.0a1 (Build ID 20190619095537) on Windows 10, macOS 10.14, and Arch Linux 4.14.3. I have also verified that the section can be collapsed/expanded, turned off/on, and that Visited Pages, Bookmarks, Most Recent Download, and Pages Saved to Pocket can be filtered out.