Closed Bug 1536296 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15843 - Support international characters in animation worklets.

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15843 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15843
Details from upstream follow.

Kevin Ellis <kevers@chromium.org> wrote:

Support international characters in animation worklets.

Code in cc/ is not permitted to use wtf::String. Thus, we perform conversions between wtf::String and std::string. The later is not aware of encodings. This is OK provided a consistent encoding is used for round tripping, where the encoding supports the set of allowed characters. The UTF-8 encoding is adequate for this task and supported by wtf::String.

Bug: 940493
Change-Id: Ie2b994412f502ea11df06713439b8cf8ffedc885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524087
Reviewed-by: Robert Flack \<flackr@chromium.org>
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641278}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 1 tests
TIMEOUT: 1

New tests that have failures or other problems:
/animation-worklet/worklet-animation-with-non-ascii-name.https.html: TIMEOUT
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb0f63216943
[wpt PR 15843] - Support international characters in animation worklets., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/aff23f7ecb9f
[wpt PR 15843] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.