1536309 - Make it possible to optionally enable frame dumps in layout-debugger in non-DEBUG builds

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P5)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Bug 1536309 - Make it possible to optionally enable frame dumps in layout-debugger in non-DEBUG builds. r=dholbert

Comment 2

[Mats Palmgren (inactive)]

Adding these lines to .mozconfig:

mk_add_options "export CXXFLAGS=-DDEBUG_FRAME_DUMP"
ac_add_options --enable-layout-debugger

makes the "Dump -> Frames" menu item work in Opt builds.

Comment 3

[Cameron McCormack (:heycam)]

Maybe --enable-layout-debugger should be enough to allow frame dumping? If --enable-layout-debugger is set, then we know we're in a non-standard configuration that we're not going to ship to users, so it shouldn't be harmful to just make frame dumping work without needing the CXXFLAGS.

Comment 4

[Mats Palmgren (inactive)]

Yeah, that's probably more convenient.

Comment 5

[Mats Palmgren (inactive)]

It would be easy to add || defined(MOZ_LAYOUT_DEBUGGER)
to the definition in nsFrameList.h, but the problem is
that MOZ_LAYOUT_DEBUGGER is just a build flag that isn't
propagated to the compiler. So, I think this patch is
good enough for now, since I don't want to deal with
build config stuff.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/732a78e6fc4f
Make it possible to optionally enable frame dumps in layout-debugger in non-DEBUG builds. r=dholbert

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/732a78e6fc4f