1536351 - PresShell::EventHandler::HandleEvent() should push current event target info before it calls HandleEventWithCurrentEventInfo()

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/layout/base/PresShell.cpp#6525-6529

Oddly, when PresShell::EventHandler::HandleEvent() sets mPresShell->mCurrentEventFrame to nullptr before HandleEventWithCurrentEventInfo() without pushing event target info when there is no event target frame and the event does not require it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1536351 - Make PresShell::EventHandler::HandleEvent() push current event info as nullptr before calling HandleEventWithCurrentEventInfo()

Oddly, when there is no frame and the handling event does not require a frame,
PresShell::EventHandler::HandleEvent() just clears
mPresShell->mCurrentEventFrame with nullptr before calling
HandleEventWithCurrentEventInfo(). This means that if event handler is
nested, old mPresShell->mCurrentEventContent is reused and
mPresShell->mCurrentEventFrame is forgotten. Therefore, it should push
nullptr as current event info instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/329f1d3e2e5a
Make PresShell::EventHandler::HandleEvent() push current event info as nullptr before calling HandleEventWithCurrentEventInfo() r=smaug

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/329f1d3e2e5a