1536444 - Tab crashes when using search and RDM (sessionHistory exception)

Status: NEW

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

STR:

• open the site search (cmd+f)
• start search for something
• close the search using ESC
• open RDM and close it again
• open the search again and start typing

ER:

• search should behave normal

AR:

• tab crashes

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Note that it may take a number of times through the STR to reproduce this (up to 10 times).

The following exceptions are raised

[Exception... "Method not implemented'Method not implemented' when calling method:
[nsIWebNavigation::sessionHistory]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"
location: "JS frame :: chrome://global/content/elements/browser-custom-element.js ::
construct :: line 1092"  data: no]

construct chrome://global/content/elements/browser-custom-element.js:1092
attributeChangedCallback chrome://global/content/elements/browser-custom-element.js:36
start resource://devtools/client/responsive.html/browser/tunnel.js:177
start resource://devtools/client/responsive.html/browser/swap.js:247
AsyncFunctionNext self-hosted:820

Observations

1. In devtools/client/responsive.html/browser/tunnel.js we set the "remote" attribute on the outer browser.
2. toolkit/content/widgets/browser-custom-element.js:26::attributeChangedCallback() detects the change and calls this.destroy() then this.construct().
3. Control returns back to devtools/client/responsive.html/browser/tunnel.js where we call outer.construct().
4. The moment we touch this.webNavigation.sessionHistory an NS_ERROR_NOT_IMPLEMENTED exception is raised (this happens the first time in step 2).
5. In dom/browser-element/BrowserElementParent.jsm:577 we intercept an "oop-frameloader-crashed" but this._frameLoader is now a dead wrapper, which triggers the "Your tab just crashed" error (which is fine because without the dead wrapper error it would still show the tab crashed tab).

The unimplemented this.webNavigation.sessionHistory is at toolkit/components/remotebrowserutils/RemoteWebNavigation.jsm:141. A comment before it says that we need to call it from content.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Push that caused this regression

Bug 1528914 - Tidy the relationship between the doc shell and the pres context. r=qdot
author Emilio Cobos Álvarez <[e-mail]>
Tue, 19 Feb 2019 22:53:40 +0000 (4 weeks ago)

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ab11369b0f9699b1badda1e8f757dc1a6ff159b6&tochange=8ed0dbecf030b172f2f12a7cc9716559c4db241b

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

@bradwerth It seems like Emilio's patch somehow causes RDM to attempt to use RemoteWebNavigation.jsm:141::sessionHistory(), which is unimplemented. This then somehow causes the page search to crash the tab... not sure why.

I am starting to suspect this needs to be fixed on the platform side.

Do you have time to take a look and if not then what would you like me to do with it?

Comment 4

[Brad Werth [:bradwerth]]

Mike, thanks for investigating this. I'll see if I can fix the tunnel setup/teardown, or the Platform code if necessary.