Closed Bug 1536463 Opened 9 months ago Closed 7 months ago

remove probe or extend the expiration date for security.pkcs11_modules_loaded telemetry probe before 2019-05-13 (firefox 69 on central), else test_pkcs11_module.js fails

Categories

(Core :: Security: PSM, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 + wontfix
firefox69 --- fixed

People

(Reporter: aryx, Assigned: jcristau)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1445961 +++

central as Gecko 69 simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=6ea532298708dad87049b38d202b3d017cf2535c&selectedJob=234778210

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=234778210&repo=try

TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_pkcs11_module.js | xpcshell return code: 0
TypeError: can't convert undefined to object at /builds/worker/workspace/build/tests/xpcshell/tests/security/manager/ssl/tests/unit/test_pkcs11_module.js:64

Flags: needinfo?(dkeeler)
Summary: remove probe or extend the expiration date for security.pkcs11_modules_loaded telemetry probe before 2019-05-13 (firefox 69 on central) → remove probe or extend the expiration date for security.pkcs11_modules_loaded telemetry probe before 2019-05-13 (firefox 69 on central), else test_pkcs11_module.js fails

We could probably just remove the probe. The way I implemented it, including the built-in modules made it hard to actually analyze the data.

Flags: needinfo?(dkeeler)

I pinged you on slack but just for the record, it would be nice if we could land this before it breaks anything in 69 but after 68 branches so we ship with the telemetry still in 68 (since that's an ESR).

Flags: needinfo?(jcristau)

I'll sit on this until the bump to 69.

Flags: needinfo?(jcristau)
Assignee: nobody → jcristau
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jcristau, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jcristau)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/aa75c6a5ee7b
remove expiring security.pkcs11_modules_loaded telemetry. r=keeler
Flags: needinfo?(jcristau)
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.