1536523 - Make `console.table` work with `performance.getEntries()`

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[jakub.g]

Attachment: console_table_performance_getentries.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

1. Open devtools on any page
2. Run in console:

A> console.table(performance.getEntries())
B> console.table(performance.getEntries(), ['type', 'name', 'duration'])

Actual results:

A> You see a table with just one column (indices of entries)
B> You see a table with (index) + 3 columns, but they are all undefined

Expected results:

You should have seen a nice table with multiple columns and their corresponding values.

It works fine in Chrome and Edge.

Perhaps the solution is to call .toJSON() on each entry before rendering its contents into console.table.

Comment 1

[jakub.g]

Attachment: console_table_tojson.png

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

This is probably because we are retrieving own properties, and entries performance data are not defined in own properties.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1536523 - Support performance.getEntries result in console.table. r=Honza.

PerformanceEntry values are put in the getterValue property in
the descriptor, so whenever we want to display a table we need
to check if the value could be in there.
This highlighted an issue in the console layout when there is a
large number of cells, which we fix in this patch.

Depends on D54260

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

TRY looks happy for the whole patch queue https://treeherder.mozilla.org/#/jobs?repo=try&revision=c28d24ff5262034ec9e2c0a857be56c8ff80c6f7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1680a0b08a76
Support performance.getEntries result in console.table. r=Honza.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1680a0b08a76