153653 - data.name == null is the wrong check

Status: RESOLVED WONTFIX

(Core Graveyard :: Skinability, defect)

Description

[timeless]

Warnung: reference to undefined property data.name
Quelldatei: 
chrome://communicator/content/pref/pref-themes.js
Zeile: 87

you'll have to excuse the line numbers and the german. I'm using live 
skin/locale switching, so the line numbers don't match.

function applySkin()
{
  var data = 
parent.hPrefWindow.wsm.dataManager.pageData["chrome://communicator/content/pref
/pref-themes.xul"];
87 <is this line>

My suggestion is that we use:
  if (!("name" in data && data.name))

-- yes, i need to find out why wsm managed to return null, but that's another 
issue.

Comment 1

[timeless]

.

Comment 2

[[e-mail]]

There's a bug that happens on a new profile; the chrome registry hasn't selected
a theme, it's defaulted to a theme, so that the theme list has no selection to
save. This then causes the panel's OK callback to get multiply registered.

Comment 3

[Philip Chee]

File and UI do not exist any more.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111104 SeaMonkey/2.7a1