Closed Bug 1536555 Opened 9 months ago Closed 8 months ago

Run Windows builds in GCP at tier 3

Categories

(Taskcluster :: Workers, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla68

People

(Reporter: coop, Assigned: grenade)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

We need to repeat the process from bug 1525094 for Windows.

Our explorations in that bug give us a good idea of the relative performance of the various available instance types in GCE. Specifically, we're using c5.4xlarge and c4.4xlarge instances in AWS and those each have 16 vCPUS, so we should be start by using the 32 vCPU-instances in GCE.

Rob is already doing experiments in bug 1531378.

I'm particularly interested in seeing the PGO builds run since they represent the critical path for release builds in GCE once we've completed a security audit of the platform.

here's some windows pgo builds on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e517ae0
i'm not sure how to go about running them at tier 3 yet, but this should give us some initial timings, sans sccache.
these are running on machine type: n1-highcpu-96 which has only marginally better performance than n1-highcpu-32 in my simple tests so far.

this change adds support for parallel gcp builds for the following windows build configurations:

  • win32
    • opt
    • debug
    • pgo
    • shippable
  • win64
    • opt
    • debug
    • pgo
    • shippable

notes:

  • gcp builds are triggered with a treeherder tier 3 flag so that they are only displayed in the treeherder ui when the user has a tier 3 flag set.
  • gcp builds use a th build symbol of "Bg" to make them easy to differentiate from ec2 builds in the treeherder ui.
  • gcp builds use a perfherder "gcp" flag to make them easier to differentiate from ec2 builds in the perfherder ui.
Attachment #9053523 - Flags: review?(pmoore)

Comment on attachment 9053523 [details]
run tc win builds on gcp at tier 3

I'm not sure why the review flag didn't get updated here, I think I've r+'d the phabricator review request (and left some comments there).

Many thanks!

Attachment #9053523 - Flags: review?(pmoore) → review+
Assignee: nobody → rthijssen
Status: NEW → ASSIGNED
Keywords: checkin-needed

Dorin tried to land this and got:

On Wed, April 3, 2019, 6:15 PM GMT+3, by dluca@mozilla.com.
Revisions: D24865 diff 83053
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpKLqxY3\npatching file taskcluster/taskgraph/util/workertypes.py\nHunk #1 FAILED at 13\n1 out of 1 hunks FAILED -- saving rejects to file taskcluster/taskgraph/util/workertypes.py.rej\npatching file taskcluster/ci/build/windows.yml\nHunk #1 FAILED at 1289\n1 out of 1 hunks FAILED -- saving rejects to file taskcluster/ci/build/windows.yml.rej\nabort: patch failed to apply', '')

Flags: needinfo?(rthijssen)
Keywords: checkin-needed

i have now manually rebased the phabricator revision against mozilla-central. should auto merge now.

Flags: needinfo?(rthijssen)
Keywords: checkin-needed

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6dc5bafd6649
run tc win builds on gcp at tier 3 r=coop,pmoore

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Blocks: 1543026
See Also: → 1543026
You need to log in before you can comment on or make changes to this bug.