1536595 - Select All does not visually highlight everything at first

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P1)

Description

[alvinhochun]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. Open certain pages (https://github.com/servo/webrender for example, scroll down a bit to see the readme text).
2. Press Ctrl+A or press "Select All" on right-click context menu.

Actual results:

Some of the texts are not visually highlighted, but they act like they're selected.

Hovering cursor over links will cause them to visually update and possibly some weird updates (e.g. hovering over the link https://hg.mozilla.org/mozilla-central twice causes some interesting changes).

Certain actions will fix the visual issue (e.g. causing the window to lose focus).

Expected results:

All texts on the page are selected and highlighted.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: selection highlight is broken.

Reproduuced without WebRender.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f74e07af9897218f5af09cc0188e753e74ecb58d&tochange=d011dfe8368374923cb69a0ab510d6814cbf3ab1

Regressed by: Bug 1533293

Nakano san, Your bunch of patch seems to cause the regression. Can you please look into this?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, thanks, I'll investigate this soon.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

I can confirm the regression range. This is happening on almost all the sites I tested. Unfortunately this is in Beta 3 as bug 1533293 landed right before the merge. We can't ship 67 with that regression and it is also a very broken behavior for our Nightly population. Masayuki, let's backout the patch on both central and beta and reland a working patch later.

Comment 4

[Jorg K (CEST = GMT+2)]

Looks like it already got backed out:

https://hg.mozilla.org/mozilla-central/rev/25398e555020
Backed out 3 changesets (bug 1533293) for causing Bug 1536595 a=backout

https://hg.mozilla.org/releases/mozilla-beta/rev/bfc174c4deb8
Backed out 3 changesets (bug 1533293) for causing Bug 1536595 a=backout

I'll let you guys set the correct flags.

FIXED by backout of bug 1533293.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Fixed by the additional patch of bug 1533293.

Comment 6

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Firefox Bug Husbandry Bot from comment #6)

Please specify a root cause for this bug. See :tmaity for more information.

Technically, explained by bug 1533293 comment 9. In other simple words, the optimization caused text frames selected by 2nd or later selection ranges not invalided properly. Therefore, the additional patch of bug 1533293 makes them invalidated when user adds a selection range because adding selection may be split to multiple ranges only when user initiated it and there are non selectable content.