Closed
Bug 1536605
Opened 5 years ago
Closed 5 years ago
New warnings in audioipc with rust 1.34 due to ATOMIC_USIZE_INIT usage
Categories
(Core :: Audio/Video: cubeb, defect, P3)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bryce, Assigned: kinetik)
References
Details
Attachments
(1 file)
The usage of ATOMIC_USIZE_INIT has been deprecated in rust 1.34, and I see errors on Windows when trying to build due to their usage in audioipc (not sure about other platforms). We should fix these upstream then grab the changes in central.
Example log below (complete with garbled characters from Windows env.):
0:31.62 [0m[0m[1m[32m Compiling[0m audioipc v0.2.4 (C:\Projects\mozilla-central\media\audioipc\audioipc)
0:32.63 [0m[1m[38;5;9merror[0m[0m[1m[38;5;15m: use of deprecated item 'std::sync::atomic::ATOMIC_USIZE_INIT': the `new` function is now preferred[0m
0:32.63 [0m [0m[0m[1m[38;5;14m--> [0m[0mmedia\audioipc\audioipc\src\messagestream_win.rs:8:48[0m
0:32.63 [0m [0m[0m[1m[38;5;14m|[0m
0:32.63 [0m[1m[38;5;14m8[0m[0m [0m[0m[1m[38;5;14m| [0m[0muse std::sync::atomic::{AtomicUsize, Ordering, ATOMIC_USIZE_INIT};[0m
0:32.63 [0m [0m[0m[1m[38;5;14m| [0m[0m [0m[0m[1m[38;5;9m^^^^^^^^^^^^^^^^^[0m
0:32.63 [0m [0m[0m[1m[38;5;14m|[0m
0:32.63 [0m [0m[0m[1m[38;5;14m= [0m[0m[1m[38;5;15mnote[0m[0m: `-D deprecated` implied by `-D warnings`[0m
0:32.63 [0m[1m[38;5;9merror[0m[0m[1m[38;5;15m: use of deprecated item 'std::sync::atomic::ATOMIC_USIZE_INIT': the `new` function is now preferred[0m
0:32.63 [0m [0m[0m[1m[38;5;14m--> [0m[0mmedia\audioipc\audioipc\src\messagestream_win.rs:103:31[0m
0:32.63 [0m [0m[0m[1m[38;5;14m|[0m
0:32.63 [0m[1m[38;5;14m103[0m[0m [0m[0m[1m[38;5;14m| [0m[0mstatic PIPE_ID: AtomicUsize = ATOMIC_USIZE_INIT;[0m
0:32.63 [0m [0m[0m[1m[38;5;14m| [0m[0m [0m[0m[1m[38;5;9m^^^^^^^^^^^^^^^^^[0m
0:32.63 [0m[1m[38;5;14mhelp[0m[0m: use of deprecated item 'std::sync::atomic::ATOMIC_USIZE_INIT': the `new` function is now preferred[0m
0:32.64 [0m [0m[0m[1m[38;5;14m|[0m
0:32.65 [0m[1m[38;5;14m103[0m[0m [0m[0m[1m[38;5;14m| [0m[0mstatic PIPE_ID: AtomicUsize = AtomicUsize::new(0);[0m
0:32.65 [0m [0m[0m[1m[38;5;14m| [0m[0m [0m[0m[1m[38;5;14m^^^^^^^^^^^^^^^^^^^[0m
0:34.09 [0m[1m[38;5;9merror[0m[0m[1m[38;5;15m: aborting due to 2 previous errors[0m
0:34.15 [0m[0m[1m[31merror:[0m Could not compile `audioipc`.
|
Reporter | |
Comment 1•5 years ago
|
||
Github issue to track upstream: https://github.com/djg/audioipc-2/issues/56
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Also includes fix for bug 1536613.
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/494ebb6edf2a Update audioipc to 9bb53d5ba11b. r=chunmin
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•