[wpt-sync] Sync PR 15873 - [Payment Request] Fix validation order of PaymentCurrencyAmount.
Categories
(Core :: DOM: Web Payments, enhancement, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 15873 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/15873
Details from upstream follow.
Danyao Wang <danyao@chromium.org> wrote:
[Payment Request] Fix validation order of PaymentCurrencyAmount.
The "check and canonicalize amount" algorithm in the spec requires that
the |currency| field is validated before the |amount| field.
https://w3c.github.io/payment-request/#validity-checkersWithout this patch, Chrome incorrectly throws TypeError instead of
RangeError when both the currency and amount are invalid.With the patch, Chrome passes the currency validation tests in
https://w3c-test.org/payment-request/PaymentRequestUpdateEvent/updateWith-method-abort-update-manual.https.htmlAlso fixed a typo in WPT test name.
Bug: 942656
Change-Id: I76b249bc1970740e0c3c9e2309bf2b9ce912450a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526434
Commit-Queue: Rouslan Solomakhin \<rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin \<rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641586}
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f52e3ec687ce4e267a4c6ed937af468ef4899fd3
|
|
Assignee | |
Comment 2•5 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/b93d3fe98d1d [wpt PR 15873] - [Payment Request] Fix validation order of PaymentCurrencyAmount., a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9e8338c453d7 [wpt PR 15873] - [Payment Request] Fix validation order of PaymentCurrencyAmount., a=testonly
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b93d3fe98d1d
https://hg.mozilla.org/mozilla-central/rev/9e8338c453d7
Description
•