Invalid modifications to SDP should result in an InvalidModificationError
Categories
(Core :: WebRTC: Signaling, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(7 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
Right now, we reject this kind of thing with InvalidSessionDescriptionError.
|
Assignee | |
Comment 1•5 years ago
|
||
We really need to simplify the way we're dealing with JSEP errors. Let's declare a single webidl enum and just use that everywhere.
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f340f4d86242de6ad225abd9dd65eeeaf8668de
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D25064
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D25146
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D25147
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D25148
|
|
Assignee | |
Comment 7•5 years ago
|
||
Depends on D25149
|
|
Assignee | |
Comment 8•5 years ago
|
||
Depends on D25150
|
|
Assignee | |
Comment 9•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e2dc6bd12e381985f75f163d62df136857f8e86
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
Reminder to deal with issues from bug 1531110 comment 3 here.
|
|
Assignee | |
Comment 11•5 years ago
|
||
Rebasing on top of bug 1531110 found some more bugs, and more bad tests.
Depends on D25151
|
|
Assignee | |
Comment 12•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1d35adab93264ff7547f4919f535d830769db6a
|
|
Assignee | |
Comment 13•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a0147bbaa70ea9a719b28db940addf2f81e0c7f
|
|
Assignee | |
Comment 14•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0c4495883ac9643c4135a7e4c94904ddf0fcbfc
|
||
Comment 15•5 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fc92485d449 Part 1: Pass the necessary information to JS to build the appropriate errors to reject with. r=smaug,jib https://hg.mozilla.org/integration/autoland/rev/ca43ce4e810e Part 2: Construct errors based on changes in part 1. r=jib https://hg.mozilla.org/integration/autoland/rev/7dcf5d093845 Part 3: Get JsepSession and PCImpl using the new error enum from part 1. r=mjf https://hg.mozilla.org/integration/autoland/rev/d2ffffe32c3b Part 4: JsepSessionTest fixes. r=mjf https://hg.mozilla.org/integration/autoland/rev/a0617985b8f5 Part 5: Stop expecting a couple of wpt to fail. r=jib https://hg.mozilla.org/integration/autoland/rev/628f21581c9a Part 6: Fix the error type that a couple of mochitests are expecting. r=jib https://hg.mozilla.org/integration/autoland/rev/86b819bf0c57 Part 7: Fix some test-cases that were expecting InvalidStateError when they should have been expecting InvalidModificationError. r=jib
|
||
Comment 16•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8fc92485d449
https://hg.mozilla.org/mozilla-central/rev/ca43ce4e810e
https://hg.mozilla.org/mozilla-central/rev/7dcf5d093845
https://hg.mozilla.org/mozilla-central/rev/d2ffffe32c3b
https://hg.mozilla.org/mozilla-central/rev/a0617985b8f5
https://hg.mozilla.org/mozilla-central/rev/628f21581c9a
https://hg.mozilla.org/mozilla-central/rev/86b819bf0c57
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16497 for changes under testing/web-platform/tests
Upstream PR merged
Description
•