Closed Bug 1536632 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 15903 - [css-grid] Fix grid container baseline alignment for orthogonal items

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15903 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15903
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

[css-grid] Fix grid container baseline alignment for orthogonal items

Grid container baseline was wrongly computed when done in reference
to an orthogonal item.
The fix is a simple change in LayoutGrid::FirstLineBoxBaseline()
to use LogicalTopForChild() so it takes into account grid container
and item writing modes.

BUG=943003
TEST=external/wpt/css/css-grid/alignment/grid-container-baseline-001.html

Change-Id: I86301933ac9ec30f6fee138cd49981bb79a4484e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528183
Reviewed-by: Javier Fernandez \<jfernandez@igalia.com>
Reviewed-by: Oriol Brufau \<obrufau@igalia.com>
Commit-Queue: Manuel Rego \<rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#641633}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d5caaef0c7
[wpt PR 15903] - [css-grid] Fix grid container baseline alignment for orthogonal items, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ef082fcaa7f
[wpt PR 15903] - [css-grid] Fix grid container baseline alignment for orthogonal items, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.