1536644 - Add support for branched add-on studies, with automatic telemetry

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement, P1)

Description

[Michael Cooper [:mythmon]]

Historically, Normandy add-on studies have had to handle branch management and marking experiments as active internally to the add-on. This has caused inconsistencies, re-work, and several bugs since the feature has been introduced. We should change that.

This bug covers introducing a new action that takes branch instructions in its arguments. Each branch will specify a slug, enrollment ratio, and an extension to use for that branch.

The extension for each branch may be duplicated, or may be null. Studies will be given a way to query the chosen branch, for studies that handle branching in a single add-on. Studies that ship one add-on per branch don't need such a query.

This action should also include enrollment events, marking telemetry experiments as active, and all other applicable Telemetry. The new action should have the same Telemetry characteristics as Preference Experiments, where possible.

Comment 1

[Michael Cooper [:mythmon]]

Attachment: Bug 1536644 - Add Branched Add-on Study action r?Gijs!,rdalal!

Comment 2

[Michael Cooper [:mythmon]]

Attachment: Bug 1536644 - Add Branched Add-on Study action

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/326fdac090f3
Add Branched Add-on Study action r=rdalal,Gijs

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 326fdac090f3 (Bug 1536644) for ESlint failure at browser_actions_BranchedAddonStudyAction.js

Backout: https://hg.mozilla.org/integration/autoland/rev/7445a65187306dfa0fc18492e7b198887a146b18

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=326fdac090f3972e60bd59a30f8fb1ea749314f3&selectedJob=251794094

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251794094&repo=autoland&lineNumber=290

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2433254cb822
Add Branched Add-on Study action r=rdalal,Gijs

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2433254cb822