Simplify accessible/tests/browser/.eslintrc.js and enable a few rules enabled in the global configuration
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(2 files)
accessible/tests/browser/.eslintrc.js contains various definitions for ESLint rules which are set to "off" unnecessarily - we don't turn them on in the default configuration for the tree. If we do, then we'd prefer to enable them everywhere so that there is as much consistency as possible.
Additionally, there's a few rules which it currently disables which are on for the rest of the tree and are trivial to enable. So I think we should enable those.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D24104
|
|
Assignee | |
Comment 3•5 years ago
|
||
To answer Alexander's comment on phabricator - yes the intention is to get our configurations as similar as possible across the tree to make it easier for developers.
There's a bit more background on my blog. We'll need to do more work over time to figure out the best options for everyone, but I'm hoping that we can largely get consistent rules everywhere for ESLint.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c681491ba94 Remove unnecessary rule definitions (obsolete, no need to override etc) in accessible/tests/browser/.eslintrc.js. r=surkov https://hg.mozilla.org/integration/autoland/rev/d03df68738c8 Enable some ESLint rules in accessible/tests/browser where they are already enabled in the global configuration. r=surkov
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5c681491ba94
https://hg.mozilla.org/mozilla-central/rev/d03df68738c8
Description
•