1536653 - Enable ESLint rule no-throw-literal in browser/

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1536653 - browser/ automated ESLint no-throw-literal fixes. r=Gijs

Result of running:
$ mach eslint -funix browser/ | sed -Ee 's/:.+//' - | xargs sed -E
-e 's/throw ((["])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["])[^"]+\2 + [^ ";]+);/throw new Error(\1);/g'
-e 's/throw (/throw new Error(/g' -i

Comment 2

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Thanks Gijs!

Sheriffs, green mochitest try with a couple known intermittents here (Apologies that it doesn't immediately show the changesets but I had "fun" with bug 1488196 showing me misleading failures, so had to redo as no-artifact without changes):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6631c70dd9e478278677f83560bb4c943cb679f1

This c-n request also includes the changeset for bug 1536648. If later child revisions from other bugs show up in the stack by the time you get to this, don't worry about them, it only needs pushing up to here
https://lando.services.mozilla.com/D24111/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2775470a624f
browser/ automated ESLint no-throw-literal fixes. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/323b02ea2926
browser/ manual ESLint no-throw-literal fixes. r=Gijs

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2775470a624f
https://hg.mozilla.org/mozilla-central/rev/323b02ea2926