Closed
Bug 1536659
Opened 5 years ago
Closed 5 years ago
Enable ESLint rule no-throw-literal in docshell/
Categories
(Core :: DOM: Navigation, enhancement)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Kwan, Assigned: Kwan)
References
Details
Attachments
(2 files)
no-throw-literal helps ensure that when we do throw errors, they come with stack traces that help track down the source of the error.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Result of running:
$ mach eslint -funix docshell/ | sed -Ee 's/:.+//' - | xargs sed -E
-e 's/throw ((["])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["])[^"]+\2 + [^ ";]+);/throw new Error(\1);/g'
-e 's/throw (/throw new Error(/g' -i
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/621f825b37e8 docshell/ automated ESLint no-throw-literal fixes. r=nika https://hg.mozilla.org/integration/autoland/rev/35240b0ae4a5 docshell/ manual ESLint no-throw-literal fixes. r=nika
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/621f825b37e8
https://hg.mozilla.org/mozilla-central/rev/35240b0ae4a5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Comment 5•5 years ago
|
||
https://hg.mozilla.org/projects/ash/rev/621f825b37e816da9e19364af21f88a281284bfd Bug 1536659 - docshell/ automated ESLint no-throw-literal fixes. r=nika https://hg.mozilla.org/projects/ash/rev/35240b0ae4a5af0c329b40e1a453cfb397f809f1 Bug 1536659 - docshell/ manual ESLint no-throw-literal fixes. r=nika
You need to log in
before you can comment on or make changes to this bug.
Description
•