Closed Bug 1536661 Opened 5 years ago Closed 4 years ago

Document splitting followup: add a RelativeRenderRoot type for typesafe renderroot multiplexing

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
Other Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: alexical, Unassigned)

References

Details

Right now we just use RenderRoot everywhere, and we understand that we occasionally have to turn RenderRoot::Default into RenderRoot::Content if the RenderRoot::Default came from a source that we know is scoped to RenderRoot::Content. We could better verify this at compile time by adding a RelativeRenderRoot type which must be converted to a RenderRoot by anything that multiplexes render roots. I.e., WebRenderBridgeParent's RenderRootForExternal would take in a RelativeRenderRoot and return a RenderRoot.

(We could also change RenderRoot to AbsoluteRenderRoot, for a bit more clarity - opinions welcome.)

I like this idea, adding safety at compile time is always good.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.