1536721 - show number of open/total issues on entire stack of revisions

Status: NEW

(Conduit :: Phabricator, enhancement, P2)

Description

[Cameron McCormack (:heycam)]

With a large patch queue, there is no single place to see which patches still have open issues that need addressing. We could show the number of open/total issues in the Stack tab on the Phabricator review itself, and/or the table in Bugzilla that shows all the Phabricator reviews for the bug.

Comment 1

[:glob ✱]

to make sure we're on the same page are you able to provide a specific example of where this information would be useful?

thanks!

Comment 2

[Cameron McCormack (:heycam)]

I have resolved all the issues now, but let's say in https://bugzilla.mozilla.org/show_bug.cgi?id=1474793 that my reviewers have given me comments to address on some of the patches. Currently, to find out if there's anything more I need to do on the patch queue before re-uploading the updated patches, I need to click each individual Dnnnn link (either from the bug, or the Stack tab on Phabricator), then either look at the file panel on the left and see if I can find any N/M numbers where N < M, or scroll down to the start of the patch (or just hit End) and look for the same in the stick bar at the top.

Comment 3

[Cameron McCormack (:heycam)]

When really what I want to know is (a) are all comments marked as resolved, and (b) if not, which patches do I need to open to look for the remaining open issues.

Comment 4

[Simon Giesecke [:sg] [he/him]]

I have a large stack as well here: https://phabricator.services.mozilla.com/D70834 where this information would be tremendously useful. I'm almost certain I am going to miss some open issue somewhere in the stack when landing no matter how hard I try without a better overview.

Comment 5

[Simon Giesecke [:sg] [he/him]]

Is there any chance of improving on this? Is there maybe an upstream feature/extension available for this? This would really help a lot.

Comment 6

[Zeid Zabaneh [:zeid] (pto)]

I can check with upstream regarding this. Given that trying to get individual revision info on the stack level hasn't been super easy in the past, I suspect this is not an easy fix on their end.

If I understand correctly, you'd like an aggregation of the outstanding unresolved comments per revision for each revision in the stack, visible in the stacks tab?

Comment 7

[Simon Giesecke [:sg] [he/him]]

Yes, displaying this information in the stack tab for each patch would be helpful. The total sum of unresolved comments is not that relevant.