1536775 - Windows try builds based on comm-esr60 fail

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1534204 +++

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=444ae4ff367a30f6a81366cdec28d47a6d6c995d
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7d9c4f8591780d2d84aa6399cf21c6cc87c183d3
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=82bbb02e82d4006e709a46527e28964b69b9dd34

They are all based on c-esr60 and they all failed with:
11:02:00 INFO - Running main action method: get_secrets
11:02:00 INFO - fetching secret project/releng/gecko/build/level-1/gapi.data from API
11:02:01 INFO - [mozharness: 2019-03-20 11:02:01.761000Z] Finished get-secrets step (failed)

See for example:
https://taskcluster-artifacts.net/EFo3YlJaTJy1t78uSnA8KA/0/public/logs/live_backing.log

Dustin, can you tell why all those try runs failed?

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

It looks like the task is trying to download secrets via taskcluster-proxy, but that feature is not enabled in the task.

I don't see that secret being fetched in a comm-central push, e.g., https://tools.taskcluster.net/groups/THDfigU3S86xbosKWqvw1g/tasks/Jwof7-9ZRHCK4YJbcvPvbA/runs/0/logs/public%2Flogs%2Flive.log

So, I'm guessing there's something that's causing esr60 to try to download that secret.

I'm no expert on mozharness, but I do recall that it looks at "actions" to see what actions it should run, and I notice that

https://hg.mozilla.org/comm-central/file/tip/taskcluster/ci/build/windows.yml

win64/opt:
    ..
    run:
        actions: [build, check-test]

whereas that is omitted in https://hg.mozilla.org/releases/comm-esr60/file/tip/taskcluster/ci/build/windows.yml. So hg blame suggests an uplift of bug 1519472. But to be clear, this is 75% speculation on my part :)

Comment 2

[Jorg K (CEST = GMT+2)]

Sigh, another missing uplift. Let's test the theory here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=163bcc5f5694d4957fcf6e752fa78bf5ab4208f1

Comment 3

[Jorg K (CEST = GMT+2)]

Oops, another backport error leading to a red D, try again:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2dffadd5af64c58a98e7dfeb2264bfdc56a866f1

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks again, Dustin, fixed by uplift in bug 1519472 comment #31:
https://hg.mozilla.org/releases/comm-esr60/rev/307afdf37c55d0efc5ae2d48506e51dcaa8625e9