1536792 - Reinstate disabled MetricsPingScheduler tests

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Michael Droettboom [:mdroettboom]]

As part of the work to fix intermittent glean tests failing, a handful of MetricsPingScheduler tests were disabled, since they were still failing.

We need to investigate why these tests were failing and restore them.

Comment 1

[Alessio Placitelli [:Dexter]]

The only test that remains to be re-enabled is: https://github.com/mozilla-mobile/android-components/blob/2b8fbc55b27255e74f2ffb7c7f07d588c6708ab5/components/service/glean/src/test/java/mozilla/components/service/glean/scheduler/MetricsPingSchedulerTest.kt#L374

Comment 2

[Travis Long [:travis_]]

I am beginning to think now that the test isn’t intermittently failing (which I can control the frequency of fairly directly now through setting a delay in the background task that is calling stringMetric.set()). I think that the test is actually intermittently successfully exposing a bug because of how quickly the background task was writing. Being able to control how often it would show up though controlling how quickly the background task was writing got me to thinking that maybe there was a slight window in which we could write to a metric, and before the call to metricsPingScheduler.startupCheck() in Glean.initialize(). It looks like from when initialized is set to true in the function, to when we call .startupCheck() is several lines of code, where it looks like it may be possible to write to a metric before the window is closed and the ping built and sent.

Comment 3

[Travis Long [:travis_]]

Attachment: GitHub Pull Request

Comment 4

[Travis Long [:travis_]]

This is suffering from some weird intermittent hangs on CI when testing that needs further investigation before I can merge and close this out.

Comment 5

[Travis Long [:travis_]]

Un-taking this and moving to M9

Comment 6

[Michael Droettboom [:mdroettboom]]

Action: Determine if still relevant, and if not, remove code.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/1149