Closed Bug 1536794 Opened 1 year ago Closed 1 year ago

Add tests to cover features implemented in bug 1533679 and bug 1533682

Categories

(Remote Protocol :: Agent, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(5 files, 1 obsolete file)

Bug 1533679 implemented support for puppeteer connect method. From CDP perspective, it means supporting:

  • /json/version http endpoint,
  • the main process target.

Bug 1533682 implemented basic support for puppeteer Browser.newPage. From CDP persective, it means supporting:

  • sessions via sessionId attribute on JSON packets,
  • a few methods and events on Target,
  • a few events on Page.

In this revision it only helps sharing handle.
But in a followup changeset, it will also help closing all the connections
and justify the sessions map we keep around.

This fixes the browser mochitest which currently timesout when calling server.close()
It started to timeout when the patch related to websocket handshake landed.

Depends on D24219

Doing this helps fixing the main target's path which is meant to be:
/devtools/browser

Depends on D24220

Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #9052326 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.