Add tests to cover features implemented in bug 1533679 and bug 1533682

RESOLVED FIXED

Status

enhancement
P1
normal
RESOLVED FIXED
a month ago
29 days ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

Details

Attachments

(5 attachments, 1 obsolete attachment)

(Assignee)

Description

a month ago

Bug 1533679 implemented support for puppeteer connect method. From CDP perspective, it means supporting:

  • /json/version http endpoint,
  • the main process target.

Bug 1533682 implemented basic support for puppeteer Browser.newPage. From CDP persective, it means supporting:

  • sessions via sessionId attribute on JSON packets,
  • a few methods and events on Target,
  • a few events on Page.
(Assignee)

Comment 1

a month ago

In this revision it only helps sharing handle.
But in a followup changeset, it will also help closing all the connections
and justify the sessions map we keep around.

(Assignee)

Comment 2

a month ago

This fixes the browser mochitest which currently timesout when calling server.close()
It started to timeout when the patch related to websocket handshake landed.

Depends on D24219

(Assignee)

Comment 3

a month ago

Doing this helps fixing the main target's path which is meant to be:
/devtools/browser

Depends on D24220

Status: NEW → ASSIGNED
Priority: -- → P1
Attachment #9052326 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.