1536794 - Add tests to cover features implemented in bug 1533679 and bug 1533682

Status: RESOLVED FIXED

(Remote Protocol :: Agent, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

Bug 1533679 implemented support for puppeteer connect method. From CDP perspective, it means supporting:

• /json/version http endpoint,
• the main process target.

Bug 1533682 implemented basic support for puppeteer Browser.newPage. From CDP persective, it means supporting:

• sessions via sessionId attribute on JSON packets,
• a few methods and events on Target,
• a few events on Page.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1536794 - Implement a base Target class.

In this revision it only helps sharing handle.
But in a followup changeset, it will also help closing all the connections
and justify the sessions map we keep around.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1536794 - Close httpd's Connection when closing the remote agent's server.

This fixes the browser mochitest which currently timesout when calling server.close()
It started to timeout when the patch related to websocket handshake landed.

Depends on D24219

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1536794 - Moving Target's path definition to a unique place, on Target class.

Doing this helps fixing the main target's path which is meant to be:
/devtools/browser

Depends on D24220

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1536794 - Add test to cover /json/version endpoint and Target domain.

Depends on D24221

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1536794 - Test Page.frameStoppedLoading and Page.navigatedWithinDocument.

Depends on D24222

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1536794 - Fix logging the stacks when an excepton happen in a json handler.

Depends on D24223

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f3f1a5f9f403
https://hg.mozilla.org/mozilla-central/rev/ad30588da467
https://hg.mozilla.org/mozilla-central/rev/ff655425368c
https://hg.mozilla.org/mozilla-central/rev/77a5006e4f17
https://hg.mozilla.org/mozilla-central/rev/d8882582edc8

Comment 8

[Ahmed Sayeed]

(In reply to Cristina Coroiu [:ccoroiu] from comment #7)

https://hg.mozilla.org/mozilla-central/rev/f3f1a5f9f403
https://hg.mozilla.org/mozilla-central/rev/ad30588da467
https://benkimimgkhn.blogspot.com/
https://hg.mozilla.org/mozilla-central/rev/ff655425368c
https://hg.mozilla.org/mozilla-central/rev/77a5006e4f17
https://hg.mozilla.org/mozilla-central/rev/d8882582edc8

Thanks