1536819 - devtools/client/inspector/rules/rules.js:461 - TypeError: node.offsetParent is null

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR

1. Open Google.com.
2. Inspect the Logo.
3. In the Rule View single click on the body selector (any selector will do).

The following error is logged to the browser console twice:

JavaScript error: resource://devtools/client/inspector/rules/rules.js, line 461: TypeError: node.offsetParent is null

This is because offsetParent is null when a node is set to display:none. We detect this situation and assume that nodeParent has an offsetParent but in this case that node is also display:none so the error is thrown.

This prevents further processing of the rules but currently doesn't cause any undesirable results.

This needs to be fixed in order to fix bug 1514998.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1536819 - Fix node.offsetParent is null error in Rule View r?gl!

The editing of selectors in the rule view is broken (see https://bugzil.la/1536867) but that is not related to this issue.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e72a35251ff8
Fix node.offsetParent is null error in Rule View r=gl

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e72a35251ff8