1536895 - FxA avatar menu Send Tab to Device can share `about:*` pages

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, enhancement)

Description

[Vijay Budhram]

This was noticed earlier today, users can share any page from the FxA avatar submenu Send Tab to Device.

These pages include about:* pages. Previously, send tab to device was only found in page specific context menus and the page action menu.

Should we allow this and/or what restrictions should be in place? Also, how should the menu look in this scenario (disabled?)

Comment 1

[Vijay Budhram]

:adavis, :rfeeley what are your thoughts on this and ux design it should have?

Comment 3

[:Gijs (he/him)]

The action doesn't actually work, right? The duplicate says that the receiving end gets a blank tab.

Seems to me we should disable it under the same circumstances where we hide the page action menu.

Comment 4

[Ryan Feeley [:rfeeley]]

We should match the behaviour of the other menus (context menu, page action menu) and disable it (reduce opacity of label and >) or is easier, hide the row entirely.

Comment 5

[Alex Davis [:adavis]]

My slight preference is to disable it and reduce opacity.

Like Feeley said, if it's easier to hide it, you can just do that.

Comment 6

[Vijay Budhram]

Attachment: Bug 1536895 - Disable send tab on Fxa avatar menu for unsupported pages

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57eb03b1dfca
Disable send tab on Fxa avatar menu for unsupported pages, r=gijs

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/57eb03b1dfca

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0b05c9bed71b

Comment 10

[Maria Berlinger [:mberlinger], Services QA]

I have managed to reproduce this issue on an affected Firefox 68.0a1 (20190320112939) build using Windows 10 x64 by following the STR:

1. Launch Firefox
2. Log in with Firefox account
3. Access one of the about:* pages (e.g. about:addons)
4. Go to Firefox Account

ER:

• "Send tab to device" option is grayed out.

AR:

• "Send tab to device" option is available.

This issue is verified fixed using Firefox 67.0b18 and Firefox 68.0a1 (20190508215144) on the following OSes: Windows 10 x64, Ubuntu 18.04 x64, Windows 7 x64, macOS 10.14.