Add breakpad id to untrusted modules ping
Categories
(External Software Affecting Firefox :: Telemetry, enhancement)
Tracking
(firefox113 fixed)
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: bugzilla, Assigned: gstoll)
References
(Blocks 1 open bug)
Details
(Whiteboard: inj+)
Attachments
(2 files)
If we pull that info, we can do more accurate joins between data sets.
|
Reporter | |
Comment 1•5 years ago
|
||
See https://github.com/dblohm7/mozdbgext/blob/master/src/bpsyms.cpp#L67 for some sample code for obtaining the ID.
|
|
Reporter | |
Comment 2•5 years ago
|
||
(Note that sample code has to read the binary using debugger APIs, whereas we can just directly parse the binary)
|
||
Comment 3•5 years ago
|
||
In the modules ping, we have the breakpad ID (https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/toolkit/components/telemetry/core/Telemetry.cpp#810 and https://searchfox.org/mozilla-central/source/tools/profiler/core/shared-libraries-win32.cc#170), which is the debug ID IIRC.
|
||
Comment 4•5 years ago
|
||
Aaron, is there a component other than Telemetry that fits this bug better?
|
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 5•5 years ago
|
||
I have created a new component for this type of telemetry, so I'll move this over there.
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 6•1 year ago
|
||
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
Pushed by gstoll@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c2b1b6360d90 add breakpad id to untrusted modules ping r=mhowell
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
|
||
Comment 9•1 year ago
|
||
Description
•