153737 - Append custom DPI setting to "Other..." font Display Resolution menu item

Status: RESOLVED INVALID

(SeaMonkey :: Preferences, defect)

Description

[Greg K.]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.1a+) Gecko/20020622
BuildID:    2002062203

When a custom DPI setting is chosen in the Appearance/Font preference pane's
"Display resolution" menu, that value should display appended to the "Other..."
menu item.

Reproducible: Always
Steps to Reproduce:
1. Select a custom DPI value such as 102 DPI
2. Reselect the menu

Actual Results:  The new custom value is not shown as one of the menu options.

Expected Results:  The new custom value should be shown as one of the menu
options (e.g., "Other... (102 DPI)").

See also IE's analogous menu.

Comment 1

[Greg K.]

Setting New.

Comment 2

[[e-mail] (away - not reading bugmail)]

interesting suggestion, Greg could you possibly get a screenshot or two and
attach them to this bug?

Comment 3

[Greg K.]

Attachment: Hacked pref-fonts.xul showing the proposed menu item change

Comment 4

[Greg K.]

In fact, it might be better to create some sort of generic user-specified menu
option for "Other..." or "Customize..." (in Message Filters) that could be used
on any menu (such as font size, which presently lacks it).

Comment 5

[Brant Gurganus]

This appears to be related so I will post this here.  If this is a separate bug,
let me know so I can file it separately.  When a custom DPI is set in build
2002122608 and a user clicks the preference to change it, a JavaScript error
appears:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIMenuBoxObject.activeChild]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> ::
onxblpopupshowing :: line 5"  data: no]

The originally reported issue also occurs on PC WinXP so I am updating theme
appropriately.  Since there is a JavaScript error, I am upping the severity to
minor.

Comment 6

[Greg K.]

Brant, that's completely different and unrelated. Please file a separate bug
about it.

Comment 7

[Brant Gurganus]

I filed it as bug 186864.  If it does turn out to be related, make sure to mark
the appropriate dependency.  Dropping severity back down since the JavaScript
error appears to be unrelated.

Comment 8

[Greg K.]

I tried editing pref-fonts.xul to make this happen, changing the appropriate
menuitem's label attribute as follows, from:
   <menuitem id="arbitraryResolution" value="other" label="&resolution.other;"/>
to:
   <menuitem id="arbitraryResolution" value="other" label="&resolution.other;
(&resolution.dpival;)"/>
in pref-fonts.xul, but it didn't work; the corresponding menu item is displayed
as "Other... ($val dpi)".

Any ideas why this doesn't work? I'm still in the process of learning XUL.

Comment 9

[Gervase Markham [:gerv]]

Check the DTD - &resolution.dpival; may well just be a placeholder, and so can't
be used that way without a conversion step.

(I'm a bit hazy on this too; it's a while since I hacked on this stuff.)

Gerv

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Mass reassign of my non-Firefox bugs to [e-mail]

Comment 11

[Serge Gautherie (:sgautherie)]

(Filter "spam" on 'prefs-nobody-20080612'.)

Comment 12

[Phoenix]

DPI setting UI gone a long ago, so closing this bug