[wpt-sync] Sync PR 15909 - Add XRSession.viewerSpace and refactor XRFrame.getPose
Categories
(Testing :: web-platform-tests, enhancement, P4)
Tracking
(firefox68 fixed)
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 15909 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/15909
Details from upstream follow.
Jacob DeWitt <jacde@chromium.org> wrote:
Add XRSession.viewerSpace and refactor XRFrame.getPose
Also check if XRFrame is an animation frame in XRFrame.getViewerPose
Instead of adding methods like GetInputSource() and ReturnTargetRay() to XRSpace,
there are 3 new classes derived from XRSpace: XRViewerSpace, XRTargetRaySpace, and
XRGripSpace. Instances of those classes can be passed as the first argument to
XRFrame.getPose to trigger the spec-required behavior for those special cases.
XRSpace has a virtual method called getPose which handles the core logic of
XRFrame.getPose. That avoids having a bunch of extra checks in the XRFrame.getPose
method itself.Bug: 928466
Change-Id: Ib4eeafe8f88b1d2ea2c2685b0112cbbd27f1b653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526788
Commit-Queue: Jacob DeWitt \<jacde@chromium.org>
Reviewed-by: Brandon Jones \<bajones@chromium.org>
Reviewed-by: Klaus Weidner \<klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642157}
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=acb597bec7e4eb7cb380dc520e83714897d4af3c
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=690946b19ff146beeeaf738e064fb74229ee4012
Assignee | ||
Comment 3•5 years ago
|
||
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b2568a966e2 [wpt PR 15909] - Add XRSession.viewerSpace and refactor XRFrame.getPose, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/548e041200a9 [wpt PR 15909] - Add XRSession.viewerSpace and refactor XRFrame.getPose, a=testonly
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b2568a966e2
https://hg.mozilla.org/mozilla-central/rev/548e041200a9
Description
•