Closed Bug 1537556 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15909 - Add XRSession.viewerSpace and refactor XRFrame.getPose

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15909 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15909
Details from upstream follow.

Jacob DeWitt <jacde@chromium.org> wrote:

Add XRSession.viewerSpace and refactor XRFrame.getPose

Also check if XRFrame is an animation frame in XRFrame.getViewerPose

Instead of adding methods like GetInputSource() and ReturnTargetRay() to XRSpace,
there are 3 new classes derived from XRSpace: XRViewerSpace, XRTargetRaySpace, and
XRGripSpace. Instances of those classes can be passed as the first argument to
XRFrame.getPose to trigger the spec-required behavior for those special cases.
XRSpace has a virtual method called getPose which handles the core logic of
XRFrame.getPose. That avoids having a bunch of extra checks in the XRFrame.getPose
method itself.

Bug: 928466
Change-Id: Ib4eeafe8f88b1d2ea2c2685b0112cbbd27f1b653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526788
Commit-Queue: Jacob DeWitt \<jacde@chromium.org>
Reviewed-by: Brandon Jones \<bajones@chromium.org>
Reviewed-by: Klaus Weidner \<klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642157}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b2568a966e2
[wpt PR 15909] - Add XRSession.viewerSpace and refactor XRFrame.getPose, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/548e041200a9
[wpt PR 15909] - Add XRSession.viewerSpace and refactor XRFrame.getPose, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.