Closed Bug 1537577 Opened 7 months ago Closed 7 months ago

--enable-warnings-as-errors fails due to -D unused-doc-comments

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: glandium, Assigned: kats)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1536045 +++

After bug 1513009 and https://github.com/rust-lang/rust/pull/57882 the following happens.

$ rustc -vV
rustc 1.35.0-nightly
binary: rustc
commit-hash: e68bf8ae15ee
commit-date: 2019-03-11
host: x86_64-unknown-freebsd
release: 1.35.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors # mimic MOZ_AUTOMATION" >>.mozconfig
$ ./mach build
[...]
error: unused doc comment
    --> gfx/wr/webrender/src/renderer.rs:5119:1
     |
5119 |   /// Flags that control how shaders are pre-cached, if at all.
     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
5120 | / bitflags! {
5121 | |     #[derive(Default)]
5122 | |     pub struct ShaderPrecacheFlags: u32 {
5123 | |         /// Needed for const initialization
...    |
5131 | |     }
5132 | | }
     | |_- rustdoc does not generate documentation for macro expansions
     |
     = note: `-D unused-doc-comments` implied by `-D warnings`
     = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion
error: aborting due to previous error
error: Could not compile `webrender`.
Assignee: nobody → kats
Priority: -- → P3
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07074627ea71
Move doc comment to fix new warning in rustc 1.35.0-nightly. r=kvark
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.