1537626 - Update command API to latest m-c code

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The command API got an overhaul, most things moved into a module. Unfortunately the module hardcodes browserAction/sidebarAction/etc but I think we can get away with this.

Now that mochitests work I've also ported the tests.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Comment 2

[Geoff Lankow (:darktrojan)]

Missing hg add somewhere along the line?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Yes, thanks for the note!

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9053167 [details] [diff] [review]
Fix - v2

Review of attachment 9053167 [details] [diff] [review]:
-----------------------------------------------------------------

r+ based on the diff between the m-c files and the c-c files.

I wonder, since ext-commands.js is the same in both trees, should we link it straight from m-c like we do with ext-pkcs11.js? It would leave us prone to breakage if they change the file, but we've got plenty of stuff like that already, what's wrong with a little more? ;-) Happy either way.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

That's fair, I guess at the time I created the ext-commands.js I was thinking I could make it influence the jsm to not add the sidebar commands.

I've started a try run just to be sure I didn't break anything locally when making the switch:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=4118b4b84b084720b3ae8a2fb74315a8fcc2769d

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

And another one because I didn't pull for 2 changesets.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ba29b827b00254d9f6ca0f8393974b2c2fb91439

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Second try run fails on some unrelated test. Looks like there are some intermittent issues with the mochitests? The first failure was also not my test.

Comment 8

[Geoff Lankow (:darktrojan)]

That failure happens sometimes.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Very well then, I'm going to assume my tests work then!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6db528de5a88
Make use of ExtensionShortcuts module and add commands API tests. r=darktrojan

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9053552 [details] [diff] [review]
Fix - v2

[Approval Request Comment]
User impact if declined: Gecko Profiler does not work without this uplift
Testing completed (on c-c, etc.): this has been working fine on nightly.
Risk to taking this patch (and alternatives if risky): Would be good to have the tests run to make sure everything is working as expected.

Comment 13

[Jorg K (CEST = GMT+2)]

TB 67 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/1889b7254762388c423a33d5403333c791814188