1537640 - Firefox adds zeros to http://192. making it really obnoxious to get to internal addresses

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Quanah Gibson-Mount]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

My firefox upgraded to release 66 tonight. It immediately exhibited a new behavior that is really annoying. If I go to the URL bar and type:

http://192.
or
https://192.

Firefox will immediately substitute 0.0.0 after the "." into the URL bar.

So to get to internal addresses like 192.168.1.1 I have to manually delete these values.

This did not happen prior to Firefox 66.

Comment 1

[Alice0775 White]

Regression window:
fromchange=d11bb3bd81951e0e5a66bc9e3ae80ca22d2ad13f&tochange=f2f4a6eb1576cba580ee99971f5fc035cbaeeab1

Regressed by:
f2f4a6eb1576 Marco Bonardo — Bug 1514780 - Use the Quantum Bar tokenizer in UnifiedComplete. r=adw

Comment 2

[Marco Bonardo [:mak]]

It looks like autofilling, that may actually be a fix rather than a bug.
is the "0.0.0" part selected? could you please attach a screenshot?

Comment 3

[Marco Bonardo [:mak]]

Nevermind, I just reproduced it using "https://192.", it looks like the Quantum Bar is not affected, the legacy urlbar is though.
If we enable the QB in 68 it may not be worth fixing this, though adding a test may be useful.

Comment 4

[Marco Bonardo [:mak]]

Standard8 noticed there's some weird behavior with the QB as well when typing "http://1"

Comment 5

[Quanah Gibson-Mount]

Hello, yes, the "." at the end is necessary for triggering the issue. :)

I only ran into this so quickly as I was setting up a brand new router when firefox updated.

Comment 6

[Marco Bonardo [:mak]]

Attachment: Bug 1537640 - Properly autofill partial IPs in the address bar. r=adw!

Trying to autofill as urls breaks our assumptions.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3779a2682cc7
Properly autofill partial IPs in the address bar. r=adw

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3779a2682cc7

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 9052997 [details]
Bug 1537640 - Properly autofill partial IPs in the address bar. r=adw!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1514780
• User impact if declined: typing IPs in the urlbar may not work as expected
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0 has most details
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small footprint patch with a test
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

This uplift looks safe as it is for a disabled feature ut given that there will be studies in 67 around Quantum bar I'd like to see this patch verified on Nightly before taking the uplift.

Comment 11

[Cristian Craciun]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Firefox/68.0
Build ID: 20190326002640

Verified as fixed on the latest Nightly build.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9052997 [details]
Bug 1537640 - Properly autofill partial IPs in the address bar. r=adw!

Limited patch fixing a visible functional regression with Quantumbar, fix verified in Nightly, uplift approved for 67 beta 6, thanks.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d86ab22b61a1

Comment 17

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/3779a2682cc744ca22372a94ea3befe0fccf7029
Bug 1537640 - Properly autofill partial IPs in the address bar. r=adw

Comment 18

[Cristian Craciun]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:67.0) Gecko/20100101 Firefox/67.0
Build ID: 20190328152334

Verified as fixed on the latest Beta build (67b6).