1537641 - Make MIDL use clang-cl

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1537641 - Make MIDL use clang-cl as a preprocessor.

Using clang-cl as a preprocessor fails with:

In file included from z:\build\build\src\accessible\ipc\win\handler\HandlerData.idl:8:
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(27,8): error: pasting formed 'Accessible2_3.', an invalid preprocessing token [-Winvalid-token-paste]
import NEWEST_IA2_IDL;
       ^
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(15,24): note: expanded from macro 'NEWEST_IA2_IDL'
                       ^
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(14,22): note: expanded from macro 'IDLFOR'
                     ^
z:\build\build\src\accessible\ipc\win\handler/AccessibleHandler.h(13,36): note: expanded from macro '__GENIDL'
                                   ^
1 error generated.
midl : command line error MIDL1003 : error returned by the C preprocessor (1)

There's only one place using the NEWEST_IA2_IDL and accompanying
macros, we can just avoid the issue altogether by expanding it manually
(and it's not like the macro buys much, the other arm of the __midl ifdef
has a #include "Accessible2_3.h" that doesn't use the macro either,
presumably for the same reason).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12b301ea0f92
Make MIDL use clang-cl as a preprocessor. r=dmajor

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/12b301ea0f92

Comment 4

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/12b301ea0f924424f0a5057f1ebccc7cd8098e8e
Bug 1537641 - Make MIDL use clang-cl as a preprocessor. r=dmajor