1537643 - Avoid using MSVC from rust build scripts

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

I don't know which one yet, but I've seen a build_script_build invoking lib.exe. My guess is lmdb-sys. With chance, this only requires setting some environment variable in config/makefiles/rust.mk.

Comment 1

[Mike Hommey [:glandium]]

I was close enough. It was lmdb-rkv-sys, but also bzip2-sys.

The bad news is, AFAICT, the cc crate doesn't allow to override lib.exe from the environment.

Comment 2

[Alex Crichton [:acrichto]]

Hm could you clarify what needs information for this? Is this a feature reuqest for cc to override lib.exe?

Comment 3

[Mike Hommey [:glandium]]

I guess this could be phrased like that. Would you prefer a github issue?

Comment 4

[Alex Crichton [:acrichto]]

Ah yeah, a github issues would be good to track it!

Comment 5

[Mike Hommey [:glandium]]

Filed https://github.com/alexcrichton/cc-rs/issues/384

Comment 6

[Nathan Froyd [:froydnj]]

Filed https://github.com/alexcrichton/cc-rs/pull/387

Comment 7

[Nathan Froyd [:froydnj]]

Attachment: Bug 1537643 - update cc crate; r=#build

This update from the official sources brings in the changes that we were
using glandium's fork for, as well as changes enabling us to tweak more
settings on Windows.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b9e5f4b0589
update cc crate; r=glandium

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1b9e5f4b0589