Closed Bug 1537643 Opened 1 year ago Closed 1 year ago

Avoid using MSVC from rust build scripts

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: glandium, Assigned: froydnj)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

I don't know which one yet, but I've seen a build_script_build invoking lib.exe. My guess is lmdb-sys. With chance, this only requires setting some environment variable in config/makefiles/rust.mk.

I was close enough. It was lmdb-rkv-sys, but also bzip2-sys.

The bad news is, AFAICT, the cc crate doesn't allow to override lib.exe from the environment.

Flags: needinfo?(acrichton)

Hm could you clarify what needs information for this? Is this a feature reuqest for cc to override lib.exe?

Flags: needinfo?(acrichton)

I guess this could be phrased like that. Would you prefer a github issue?

Flags: needinfo?(acrichton)
Blocks: 1538043

Ah yeah, a github issues would be good to track it!

Flags: needinfo?(acrichton)

This update from the official sources brings in the changes that we were
using glandium's fork for, as well as changes enabling us to tweak more
settings on Windows.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.