Avoid using MSVC from rust build scripts

RESOLVED FIXED in Firefox 68

Status

enhancement
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: glandium, Assigned: froydnj)

Tracking

(Blocks 2 bugs)

unspecified
mozilla68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 months ago

I don't know which one yet, but I've seen a build_script_build invoking lib.exe. My guess is lmdb-sys. With chance, this only requires setting some environment variable in config/makefiles/rust.mk.

Reporter

Comment 1

2 months ago

I was close enough. It was lmdb-rkv-sys, but also bzip2-sys.

The bad news is, AFAICT, the cc crate doesn't allow to override lib.exe from the environment.

Flags: needinfo?(acrichton)

Hm could you clarify what needs information for this? Is this a feature reuqest for cc to override lib.exe?

Flags: needinfo?(acrichton)
Reporter

Comment 3

2 months ago

I guess this could be phrased like that. Would you prefer a github issue?

Flags: needinfo?(acrichton)
Reporter

Updated

2 months ago
Blocks: 1538043

Ah yeah, a github issues would be good to track it!

Flags: needinfo?(acrichton)
Assignee

Comment 7

2 months ago

This update from the official sources brings in the changes that we were
using glandium's fork for, as well as changes enabling us to tweak more
settings on Windows.

Comment 9

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → nfroyd
You need to log in before you can comment on or make changes to this bug.