1537668 - Refactor how clip task indices are passed to shaders.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1537668 - Refactor how clip task indices are passed to shaders.

This patch shouldn't have any functional effect. It's motivated by
some changes needed to implement clip masks in pixel local storage,
but these are also general improvements that stand alone. Specifically:

• Remove clip_task_index from the global PrimitiveHeader struct.
  In most cases, the clip task is supplied in the BrushInstance
  structure, so it makes no sense to have this as a common field,
  where it is generally unused. Instead, there is now an extra
  'user data' field available in the PrimitiveHeader. Non-brush
  shaders (text_run and split_composite) use that extra field to
  store the clip task address, while the brush shaders gain an extra
  (currently unused) user data field.
• In turn, this means there is no need to unconditionally try
  and retrieve the first clip task address for a primitive
  during batching. This was previously used to initialize the
  PrimitiveHeader structure.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1669162b7ab
Refactor how clip task indices are passed to shaders. r=kvark

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e1669162b7ab