Use llvm-mt.exe instead of mt.exe when available
Categories
(Firefox Build System :: General, enhancement)
Tracking
(Not tracked)
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 obsolete file)
MT is part of the Windows SDK, not MSVC, but an alternative exists for it: llvm-mt. The official LLVM distribution for Windows doesn't include it[1], though, so we can't just switch to it.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
MT is part of the Windows SDK, not MSVC, but an alternative exists for
it: llvm-mt. The official LLVM distribution for Windows doesn't include
it[1], though, so we can't just switch to it.
While here, remove the .exe suffix from the check, to future-proof for
cross-windows builds.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/40832d187454 Use llvm-mt.exe instead of mt.exe when available. r=dmajor
Comment 3•5 years ago
|
||
Backed out changeset 40832d187454 (bug 1537669) for causing ActivationContext.cpp asertion failures
push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=235328305&revision=40832d18745436bf9521334193728de42f3d67d5
backout: https://hg.mozilla.org/integration/autoland/rev/63df58e1fae0c4254c2826524bd8184fb161045f
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
So it turns out llvm-mt was found by configure, but that disabled running mt entirely because of MSMANIFEST_TOOL. Now, with fixing this, we end up with:
04:03:31 INFO - llvm-mt: error: no libxml2
04:03:31 INFO - llvm-mt: ignoring unsupported 'outputresource:' option
which doesn't sound great.
Assignee | ||
Comment 5•5 years ago
|
||
That no libxml2
error is behind a #ifndef LLVM_LIBXML2_ENABLED
, and from a quick glance at the cmake files, building on Windows never enables libxml2.
Comment 6•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:glandium, could you have a look please?
Assignee | ||
Comment 7•5 years ago
|
||
Can the release mgmt bot treat backed out bugs differently?
Comment 8•5 years ago
|
||
Yeah, we should ignore then. I reported https://github.com/mozilla/relman-auto-nag/issues/628 for that
Assignee | ||
Comment 9•4 years ago
|
||
Turns out llvm-mt is useless in its current implementation. All it does is merge manifests, and we don't even do that. It can't embed a manifest in a binary. For Windows cross-builds, I'm going to try to move off MT entirely instead.
Updated•4 years ago
|
Description
•